[jira] [Commented] (FALCON-913) Change the default values of log clean up services

["Shwetha G S (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FALCON-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226040#comment-14226040 ] 

Shwetha G S commented on FALCON-913:
------------------------------------

{code}
+        case minutes:
+            return RuntimeProperties.get().getProperty("log.cleanup.frequency." + timeunit + ".retention",
+                    "hours(24)");
+
+        case hours:
+            return RuntimeProperties.get().getProperty("log.cleanup.frequency." + timeunit + ".retention",
+                    "days(3)");
{code}
can you set the default in switch case and move return statement outside the loop?

Can you also remove the defaults from runtime properties as the code already has sane defaults? 


> Change the default values of log clean up services
> --------------------------------------------------
>
>                 Key: FALCON-913
>                 URL: https://issues.apache.org/jira/browse/FALCON-913
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Suhas Vasu
>            Assignee: Suhas Vasu
>            Priority: Minor
>         Attachments: FALCON-913.patch
>
>
> The current values of log clean up services are a bit aggressive. If someone doesn't change this, he/she may run into unexpected issues.
> One of the issues that arised from this scenario was - 
> The log clean up deleted all files and the service deleted the log directory as it was empty. The next successful instance failed in post processing, as it had incorrect permissions to create the log dir. This will cause confusion among users who are new to falcon.
> I suggest to relax the frequency of clean up services.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)