[GitHub] kaxil commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook
URL: https://github.com/apache/airflow/pull/4584#discussion_r251136895
 
 

 ##########
 File path: airflow/hooks/oracle_hook.py
 ##########
 @@ -48,22 +48,65 @@ def get_conn(self):
               that you are connecting to (CONNECT_DATA part of TNS)
         You can set these parameters in the extra fields of your connection
         as in ``{ "dsn":"some.host.address" , "service_name":"some.service.name" }``
+        see more param detail in
+        ``https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect``
         """
         conn = self.get_connection(self.oracle_conn_id)
+        conn_config = {
+            'user': conn.login,
 
 Review comment:
   Maybe add a condition block to check if `login` & `password` fields are not empty and raise an error that they are required if it is empty.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services