[GitHub] hequn8128 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

[GitBox <gi...@apache.org>]

hequn8128 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API
URL: https://github.com/apache/flink/pull/7209#discussion_r241948923
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
 ##########
 @@ -1028,6 +1061,119 @@ class Table(
   }
 }
 
+class FlatAggTable(
 
 Review comment:
   I hesitate to remove `FlagAggTable`. 
   - Even `FlatAggTable` and `GroupedFlatAggTable` share same methods now, I'm not sure if there is a chance that `FlatAggTable` will be different from `GroupedFlatAggTable` later. At that time, we should add `FlatAggTable` back which will break compatibility.
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services