[GitHub] [incubator-doris] morningman commented on a change in pull request #8000: [fix](compatibility) Fix compatibility issue of PRowBatch and some tablet sink bugs

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #8000:
URL: https://github.com/apache/incubator-doris/pull/8000#discussion_r804365648



##########
File path: be/src/exec/tablet_sink.cpp
##########
@@ -571,7 +577,7 @@ void IndexChannel::add_row(Tuple* tuple, int64_t tablet_id) {
         // if this node channel is already failed, this add_row will be skipped
         auto st = channel->add_row(tuple, tablet_id);
         if (!st.ok()) {
-            mark_as_failed(channel, st.get_error_msg(), tablet_id);
+            mark_as_failed(channel.get(), st.get_error_msg(), tablet_id);

Review comment:
       I think it is not necessary, and it will cause extra shared ptr copy.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org