You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/05/22 07:24:50 UTC
[GitHub] carbondata pull request #2331: [CARBONDATA-2507] enable.offheap.sort not val...
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2331
[CARBONDATA-2507] enable.offheap.sort not validate in CarbonData
In https://github.com/apache/carbondata/pull/2274, the value of "enable.offheap.sort" will transform to false when args[0] not equal to true, including "false" and other string, like "f","any" and so on.
So we should validate it.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
No
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
No
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
No
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata CARBONDATA-2507-validateProperties
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2331
----
commit 42051fe1104ad012ada5172303417545e7a137e7
Author: xubo245 <xu...@...>
Date: 2018-05-22T07:20:21Z
[CARBONDATA-2507] Some properties not validate in CarbonData, like enable.offheap.sort
----
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2331
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4912/
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2331
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5068/
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2331
LGTM
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2331
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4905/
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2331
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6073/
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2331
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6039/
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2331
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4880/
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2331
@sraghunandan @rahulforallp This PR fix possible problem in #2274, Please review it.
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2331
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5051/
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2331
Are there any parameter need validate ?
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on the issue:
https://github.com/apache/carbondata/pull/2331
LGTM
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2331
retest this please
---
[GitHub] carbondata issue #2331: [CARBONDATA-2507] enable.offheap.sort not validate i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2331
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6065/
---
[GitHub] carbondata pull request #2331: [CARBONDATA-2507] enable.offheap.sort not val...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2331
---