You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by mm...@apache.org on 2021/01/27 13:21:43 UTC
[accumulo] branch main updated (ecddf35 -> 6af856b)
This is an automated email from the ASF dual-hosted git repository.
mmiller pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo.git.
from ecddf35 Merge remote-tracking branch 'upstream/1.10' into main
add ed97eac Make UnloadTabletHandler log before waiting (#1881)
new 6af856b Merge remote-tracking branch 'upstream/1.10' into main
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../src/main/java/org/apache/accumulo/tserver/UnloadTabletHandler.java | 1 +
1 file changed, 1 insertion(+)
[accumulo] 01/01: Merge remote-tracking branch 'upstream/1.10' into
main
Posted by mm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mmiller pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo.git
commit 6af856b38bb57f49418547a8b9c262c66a1fe31e
Merge: ecddf35 ed97eac
Author: Mike Miller <mm...@apache.org>
AuthorDate: Wed Jan 27 08:20:57 2021 -0500
Merge remote-tracking branch 'upstream/1.10' into main
.../src/main/java/org/apache/accumulo/tserver/UnloadTabletHandler.java | 1 +
1 file changed, 1 insertion(+)
diff --cc server/tserver/src/main/java/org/apache/accumulo/tserver/UnloadTabletHandler.java
index e3978f0,0000000..798d7b4
mode 100644,000000..100644
--- a/server/tserver/src/main/java/org/apache/accumulo/tserver/UnloadTabletHandler.java
+++ b/server/tserver/src/main/java/org/apache/accumulo/tserver/UnloadTabletHandler.java
@@@ -1,141 -1,0 +1,142 @@@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.accumulo.tserver;
+
+import static java.util.concurrent.TimeUnit.MILLISECONDS;
+import static java.util.concurrent.TimeUnit.NANOSECONDS;
+
+import org.apache.accumulo.core.conf.Property;
+import org.apache.accumulo.core.dataImpl.KeyExtent;
+import org.apache.accumulo.core.master.thrift.TabletLoadState;
+import org.apache.accumulo.core.metadata.TServerInstance;
+import org.apache.accumulo.core.metadata.TabletLocationState;
+import org.apache.accumulo.core.metadata.TabletLocationState.BadLocationStateException;
+import org.apache.accumulo.core.tabletserver.thrift.TUnloadTabletGoal;
+import org.apache.accumulo.server.master.state.DistributedStoreException;
+import org.apache.accumulo.server.master.state.TabletStateStore;
+import org.apache.accumulo.tserver.mastermessage.TabletStatusMessage;
+import org.apache.accumulo.tserver.tablet.Tablet;
+import org.apache.zookeeper.KeeperException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+class UnloadTabletHandler implements Runnable {
+ private static final Logger log = LoggerFactory.getLogger(UnloadTabletHandler.class);
+ private final KeyExtent extent;
+ private final TUnloadTabletGoal goalState;
+ private final long requestTimeSkew;
+ private final TabletServer server;
+
+ public UnloadTabletHandler(TabletServer server, KeyExtent extent, TUnloadTabletGoal goalState,
+ long requestTime) {
+ this.extent = extent;
+ this.goalState = goalState;
+ this.server = server;
+ this.requestTimeSkew = requestTime - MILLISECONDS.convert(System.nanoTime(), NANOSECONDS);
+ }
+
+ @Override
+ public void run() {
+
+ Tablet t = null;
+
+ synchronized (server.unopenedTablets) {
+ if (server.unopenedTablets.contains(extent)) {
+ server.unopenedTablets.remove(extent);
+ // enqueueMasterMessage(new TabletUnloadedMessage(extent));
+ return;
+ }
+ }
+ synchronized (server.openingTablets) {
+ while (server.openingTablets.contains(extent)) {
+ try {
++ log.info("Waiting for tablet {} to finish opening before unloading.", extent);
+ server.openingTablets.wait();
+ } catch (InterruptedException e) {}
+ }
+ }
+ synchronized (server.onlineTablets) {
+ if (server.onlineTablets.snapshot().containsKey(extent)) {
+ t = server.onlineTablets.snapshot().get(extent);
+ }
+ }
+
+ if (t == null) {
+ // Tablet has probably been recently unloaded: repeated master
+ // unload request is crossing the successful unloaded message
+ if (!server.recentlyUnloadedCache.containsKey(extent)) {
+ log.info("told to unload tablet that was not being served {}", extent);
+ server.enqueueMasterMessage(
+ new TabletStatusMessage(TabletLoadState.UNLOAD_FAILURE_NOT_SERVING, extent));
+ }
+ return;
+ }
+
+ try {
+ t.close(!goalState.equals(TUnloadTabletGoal.DELETED));
+ } catch (Exception e) {
+
+ if ((t.isClosing() || t.isClosed()) && e instanceof IllegalStateException) {
+ log.debug("Failed to unload tablet {}... it was already closing or closed : {}", extent,
+ e.getMessage());
+ } else {
+ log.error("Failed to close tablet {}... Aborting migration", extent, e);
+ server.enqueueMasterMessage(new TabletStatusMessage(TabletLoadState.UNLOAD_ERROR, extent));
+ }
+ return;
+ }
+
+ // stop serving tablet - client will get not serving tablet
+ // exceptions
+ server.recentlyUnloadedCache.put(extent, System.currentTimeMillis());
+ server.onlineTablets.remove(extent);
+
+ try {
+ TServerInstance instance =
+ new TServerInstance(server.clientAddress, server.getLock().getSessionId());
+ TabletLocationState tls = null;
+ try {
+ tls = new TabletLocationState(extent, null, instance, null, null, null, false);
+ } catch (BadLocationStateException e) {
+ log.error("Unexpected error", e);
+ }
+ if (!goalState.equals(TUnloadTabletGoal.SUSPENDED) || extent.isRootTablet()
+ || (extent.isMeta()
+ && !server.getConfiguration().getBoolean(Property.MANAGER_METADATA_SUSPENDABLE))) {
+ TabletStateStore.unassign(server.getContext(), tls, null);
+ } else {
+ TabletStateStore.suspend(server.getContext(), tls, null,
+ requestTimeSkew + MILLISECONDS.convert(System.nanoTime(), NANOSECONDS));
+ }
+ } catch (DistributedStoreException ex) {
+ log.warn("Unable to update storage", ex);
+ } catch (KeeperException e) {
+ log.warn("Unable determine our zookeeper session information", e);
+ } catch (InterruptedException e) {
+ log.warn("Interrupted while getting our zookeeper session information", e);
+ }
+
+ // tell the master how it went
+ server.enqueueMasterMessage(new TabletStatusMessage(TabletLoadState.UNLOADED, extent));
+
+ // roll tablet stats over into tablet server's statsKeeper object as
+ // historical data
+ server.statsKeeper.saveMajorMinorTimes(t.getTabletStats());
+ }
+}