[GitHub] [iceberg] pvary commented on a diff in pull request #6570: Hive: Use EnvironmentContext instead of Hive Locks to provide transactional commits after HIVE-26882

["pvary (via GitHub)" <gi...@apache.org>]

pvary commented on code in PR #6570:
URL: https://github.com/apache/iceberg/pull/6570#discussion_r1148316854


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -303,6 +303,9 @@ private TableProperties() {}
   public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
   public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
 
+  public static final String HIVE_LOCK_ENABLED = "hive.lock.enabled";
+  public static final boolean HIVE_LOCK_ENABLED_DEFAULT = true;

Review Comment:
   Done 



##########
core/src/main/java/org/apache/iceberg/hadoop/ConfigProperties.java:
##########
@@ -23,5 +23,6 @@ public class ConfigProperties {
   private ConfigProperties() {}
 
   public static final String ENGINE_HIVE_ENABLED = "iceberg.engine.hive.enabled";
+  public static final String LOCK_HIVE_ENABLED = "iceberg.lock.hive.enabled";

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org