[GitHub] [geode] upthewaterspout commented on pull request #7303: GEODE-9987: Refactored/Removal of deprecated APIs

[GitBox <gi...@apache.org>]

upthewaterspout commented on pull request #7303:
URL: https://github.com/apache/geode/pull/7303#issuecomment-1039422049


   It's not clear to me how these changes relate to GEODE-9987. That bug was a failure saying "Member isn't responding to heartbeat requests". I don't think this refactoring is going to affect that type of failure - usually that would indicate resource issues on the CI machine or perhaps the need for a larger membership-timeout for this test? It does look like this test probably doesn't need to start so many locators, maybe that would help?
   
   I'm not sure how I feel about removing the port 0 test. It looks like it was trying to test that members that start up with port 0 as the locator port correctly distribute the *actual* port of the locator to other members, rather than 0? Is the reason you think port 0 is going to cause port conflicts because other tests are using AvailablePortHelper? Seems like we still need a way to write tests that using port 0 actually works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org