You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/31 14:01:15 UTC

[GitHub] [cordova] raphinesse opened a new pull request #240: Add dependency overview to README.md

raphinesse opened a new pull request #240:
URL: https://github.com/apache/cordova/pull/240


   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Provide a high-level overview about the package relationships in a prominent place.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Added a sketchy dependency graph of a subset of Cordova. Including a link to the Graphviz source code, so the graph can be adjusted if necessary.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova] brodybits commented on pull request #240: Add dependency overview to README.md

Posted by GitBox <gi...@apache.org>.
brodybits commented on pull request #240:
URL: https://github.com/apache/cordova/pull/240#issuecomment-683992142


   Any way we could add the code, as a comment for example?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova] raphinesse commented on pull request #240: Add dependency overview to README.md

Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #240:
URL: https://github.com/apache/cordova/pull/240#issuecomment-683988308


   > Looks good to me. Nice tool! Should we add the image file to repo in case the URL goes down?
   
   Possible drawback of NOT adding the image to the repo: I can change it to anything I want by editing the code in my gist. :grin: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova] raphinesse edited a comment on pull request #240: Add dependency overview to README.md

Posted by GitBox <gi...@apache.org>.
raphinesse edited a comment on pull request #240:
URL: https://github.com/apache/cordova/pull/240#issuecomment-683981908


   > Looks good to me. Nice tool! Should we add the image file to repo in case the URL goes down?
   
   I personally wouldn't bother as the source code for the diagram is [saved in a gist](https://gist.github.com/raphinesse/a6f28acb2281b782d9fb5ef486834deb) and the image (sans sketchiness) can be recreated with regular `graphviz`. Plus, it would be one more place to update if the graph were to change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova] raphinesse commented on pull request #240: Add dependency overview to README.md

Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #240:
URL: https://github.com/apache/cordova/pull/240#issuecomment-683998876


   > > Looks good to me. Nice tool! Should we add the image file to repo in case the URL goes down?
   > 
   > Possible drawback of NOT adding the image to the repo: I can change it to anything I want by editing the code in my gist.
   
   Sorry, that's not true. The image references a specific version of the gist.
   
   
   > Any way we could add the code, as a comment for example?
   
   I thought about that, but the code would be duplicated between the comment and the gist, having a negative impact on maintainability. An alternative (non-sketchy) approach would be to use that glitch service that I used for prior graphs. Its links contain the graph code as an url parameter: https://graphviz2.glitch.me/?graph=digraph+%22Cordova+Dependencies%22+%7B%0Acli+-%3E+%7Blib%2C+create%2C+common%7D%3B%0Aplugman+-%3E+lib%3B%0Alib+-%3E+%7Bfetch%2C+serve%2C+common%7D%3B%0Alib+-%3E+platforms+%5Bstyle%3Ddotted%5D%3B%0Acreate+-%3E+%7Bfetch%2C+%22app-hello-world%22%2C+common%7D%3B%0Afetch+-%3E+common%3B%0A%0Aplatforms+%5Bshape%3Drecord+label%3D%22%7BPlatforms%7C%7B%3Call%3E*%7C%3Capple%3Eios%2C+osx%7C%3Cwww%3Ebrowser%7D%7D%22%5D%3B%0Aplatforms%3Aapple+-%3E+%22node-xcode%22%3B%0Aplatforms%3Awww+-%3E+serve%3B%0Aplatforms%3Aall+-%3E+common%3B%0Aplatforms%3Aall+-%3E+js+%5Bstyle%3Ddotted%5D%3B%0A%7D%0A


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova] raphinesse merged pull request #240: Add dependency overview to README.md

Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #240:
URL: https://github.com/apache/cordova/pull/240


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova] raphinesse merged pull request #240: Add dependency overview to README.md

Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #240:
URL: https://github.com/apache/cordova/pull/240


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova] raphinesse commented on pull request #240: Add dependency overview to README.md

Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #240:
URL: https://github.com/apache/cordova/pull/240#issuecomment-683981908


   > Looks good to me. Nice tool! Should we add the image file to repo in case the URL goes down?
   
   I personally wouldn't bother as the source code for the diagram is [saved in a gist](https://gist.github.com/raphinesse/a6f28acb2281b782d9fb5ef486834deb) and the image (sans sketchiness) can be recreated with regular `graphviz`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org