You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/20 18:09:44 UTC
[GitHub] [airflow] okayhooni opened a new pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()
okayhooni opened a new pull request #22386:
URL: https://github.com/apache/airflow/pull/22386
Even though smart sensor feature was deprecated and planned to be removed on version 2.4, the fact that sensor tasks with any callback arguments are not compatible with smart sensor, has to be noticed on the official docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22386:
URL: https://github.com/apache/airflow/pull/22386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #22386:
URL: https://github.com/apache/airflow/pull/22386#discussion_r830732593
##########
File path: docs/apache-airflow/concepts/smart-sensors.rst
##########
@@ -85,6 +85,8 @@ It is transparent to the individual users. Existing DAGs don't need to be change
enabling/disabling the smart sensor. Rotating centralized smart sensor tasks will not
cause any user’s sensor task failure.
+* Callback arguments(``on_success_callback``, ``on_failure_callback``, and ``on_retry_callback``) on sensor operator are not compatible with smart sensor. If any callback arguments is provided, that sensor task will not be executed on smart sensor.
Review comment:
```suggestion
* Using callback arguments (``on_success_callback``, ``on_failure_callback``, and ``on_retry_callback``) on a sensor task is not compatible with the smart sensor mode. If any callback arguments are provided, the sensor task will not be executed when the smart sensor mode is enabled.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #22386:
URL: https://github.com/apache/airflow/pull/22386#discussion_r830732593
##########
File path: docs/apache-airflow/concepts/smart-sensors.rst
##########
@@ -85,6 +85,8 @@ It is transparent to the individual users. Existing DAGs don't need to be change
enabling/disabling the smart sensor. Rotating centralized smart sensor tasks will not
cause any user’s sensor task failure.
+* Callback arguments(``on_success_callback``, ``on_failure_callback``, and ``on_retry_callback``) on sensor operator are not compatible with smart sensor. If any callback arguments is provided, that sensor task will not be executed on smart sensor.
Review comment:
```suggestion
* Using callback arguments (``on_success_callback``, ``on_failure_callback``, and ``on_retry_callback``) on a sensor task is not compatible with the smart sensor mode. If any callback arguments are provided, the sensor task will not be executed when smart sensor is enabled.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #22386:
URL: https://github.com/apache/airflow/pull/22386#issuecomment-1073303680
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #22386:
URL: https://github.com/apache/airflow/pull/22386#discussion_r830732593
##########
File path: docs/apache-airflow/concepts/smart-sensors.rst
##########
@@ -85,6 +85,8 @@ It is transparent to the individual users. Existing DAGs don't need to be change
enabling/disabling the smart sensor. Rotating centralized smart sensor tasks will not
cause any user’s sensor task failure.
+* Callback arguments(``on_success_callback``, ``on_failure_callback``, and ``on_retry_callback``) on sensor operator are not compatible with smart sensor. If any callback arguments is provided, that sensor task will not be executed on smart sensor.
Review comment:
```suggestion
* Using callback arguments (``on_success_callback``, ``on_failure_callback``, and ``on_retry_callback``) on a sensor task is not compatible with the smart sensor mode. If any callback arguments are provided, the sensor task will not be executed in the smart sensor mode.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #22386:
URL: https://github.com/apache/airflow/pull/22386#discussion_r830732593
##########
File path: docs/apache-airflow/concepts/smart-sensors.rst
##########
@@ -85,6 +85,8 @@ It is transparent to the individual users. Existing DAGs don't need to be change
enabling/disabling the smart sensor. Rotating centralized smart sensor tasks will not
cause any user’s sensor task failure.
+* Callback arguments(``on_success_callback``, ``on_failure_callback``, and ``on_retry_callback``) on sensor operator are not compatible with smart sensor. If any callback arguments is provided, that sensor task will not be executed on smart sensor.
Review comment:
```suggestion
* Using callback arguments (``on_success_callback``, ``on_failure_callback``, and ``on_retry_callback``) on a sensor task is not compatible with the smart sensor mode. If any callback arguments are provided, the sensor task will not be executed in smart sensor mode.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22386:
URL: https://github.com/apache/airflow/pull/22386#issuecomment-1077354333
Random failure. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22386:
URL: https://github.com/apache/airflow/pull/22386#issuecomment-1073449652
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #22386:
URL: https://github.com/apache/airflow/pull/22386#issuecomment-1077354439
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org