You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/01/04 14:27:02 UTC
[GitHub] [dolphinscheduler-website] RedemptionC opened a new pull request #618: Fix format
RedemptionC opened a new pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618
1. In this doc,these two lines are decorated with h5 title,which seems a little weird,maybe bold-face works better here.
2. this line seems to be a typo:
```
Server基于netty提供监听服务。Worker
```
I changed it to:
```
WorkerServer基于netty提供监听服务。
```
Please correct me if that's not true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] RedemptionC removed a comment on pull request #618: Fix format
Posted by GitBox <gi...@apache.org>.
RedemptionC removed a comment on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1004862227
It seems that many versions of doc are written this way,but I think case 1 maybe be a convention,while case 2 just doesn't really make sense👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] dailidong commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1005731821
good job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] RedemptionC commented on pull request #618: Fix format
Posted by GitBox <gi...@apache.org>.
RedemptionC commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1004858263
@CalvinKirs @lenboo @dailidong please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] RedemptionC edited a comment on pull request #618: Fix format
Posted by GitBox <gi...@apache.org>.
RedemptionC edited a comment on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1004858263
@CalvinKirs @lenboo @dailidong please take a look
It seems that many versions of doc are written this way,but I think case 1 maybe be a convention,while case 2 just doesn't really make sense👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie edited a comment on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie edited a comment on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1007124701
BTW, I add two issue you said above to apache/dolphinscheduler#6535 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1005896077
Hi, @RedemptionC @zhuangchong @dailidong When changing doc, please make sure we change all document in all versions, in this patch we should also change version `1.3.1 - 1.3.8` and `dev` document. @RedemptionC Do you have a time to add another PR to fix them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] RedemptionC commented on pull request #618: Fix format
Posted by GitBox <gi...@apache.org>.
RedemptionC commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1004862227
It seems that many versions of doc are written this way,but I think case 1 maybe be a convention,while case 2 just doesn't really make sense👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1006261697
> Hi, @zhongjiajie I've noticed that many versions of 1.3.x Doc are written this way In fact,I was intending to ask advice on modification so that I can change all of them if my understanding on this modification is true But somehow it was merged directly
Ok, then maybe you could submit new PR to correct them. One more things, we just release 202 document, you should also change 2.0.2 doc as well, thank 🎉 @RedemptionC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1007124701
BTW, I add two issue you said above to apache/dolphinscheduler#6535 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1006319922
> The point is advice.
@RedemptionC Yeah, I got this, if you're the user or you start to learn DolphinScheduler, you should learn our document. If you found our doc has wrong content(I mean maybe our UI without the element, can not do something like doc, or maybe have misleading) you could just create a new issue in https://github.com/apache/dolphinscheduler/issues.
And, Yes, you're right, we should export as more detail as possible in our document, but not in codebase, we are trying but it seems our maintainer do not have enough time to do it, So we help community could helping, we create todo list in https://github.com/apache/dolphinscheduler/issues/6535, feel free to take it if you want to build our community together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhuangchong merged pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhuangchong merged pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] SunnyZ-L commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
SunnyZ-L commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1007870016
> FYI @RedemptionC @SunnyZ-L , up to now, our document has many mistake/misleading. I and my team try to make our document more efficient and correct. But it seems we need more help from the community. Cause we do not have enough time to find and correct all our documents.
>
> The only thing I could do is record all issues related to doc in [apache/dolphinscheduler#6535](https://github.com/apache/dolphinscheduler/issues/6535). And correct some emergencies. But we could not do all the things, at least at this time. So I hope someone could give some help.
I can help with the construction and improvement of the documentation, Next, I will gradually select the problems in [apache/dolphinscheduler#6535](https://github.com/apache/dolphinscheduler/issues/6535) to complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1007123849
FYI @RedemptionC @SunnyZ-L , up to now, our document has many mistake/misleading. I and my team try to make our document more efficient and correct. But it seems we need more help from the community. Cause we do not have enough time to find and correct all our documents.
The only thing I could do is record all issues related to doc in https://github.com/apache/dolphinscheduler/issues/6535. And correct some emergencies. But we could not do all the things, at least at this time. So I hope someone could give some help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] SunnyZ-L commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
SunnyZ-L commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1007870016
> FYI @RedemptionC @SunnyZ-L , up to now, our document has many mistake/misleading. I and my team try to make our document more efficient and correct. But it seems we need more help from the community. Cause we do not have enough time to find and correct all our documents.
>
> The only thing I could do is record all issues related to doc in [apache/dolphinscheduler#6535](https://github.com/apache/dolphinscheduler/issues/6535). And correct some emergencies. But we could not do all the things, at least at this time. So I hope someone could give some help.
I can help with the construction and improvement of the documentation, Next, I will gradually select the problems in [apache/dolphinscheduler#6535](https://github.com/apache/dolphinscheduler/issues/6535) to complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1008290590
@SunnyZ-L What a good news, thanks and looking forward your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhuangchong commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1005468955
@RedemptionC
the maser-server sends tasks to the worker-server through netty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie edited a comment on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie edited a comment on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1008290590
@SunnyZ-L What good news, thanks, and looking forward to your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] RedemptionC commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
RedemptionC commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1005463666
@zhuangchong thanks for your review!
BTW, I want to confirm this:
is this modification reasonable? I don't really know how the workerServer work, I just try to make it sound right grammatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] RedemptionC commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
RedemptionC commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1006280133
@zhongjiajie
The point is advice.
Actually,I'm learning DS via this Doc. Considering my knowledge on DS,I can only recognize obvious typo.When it comes to confusion about the internals,I raised questions.
Perhaps the doc should be maintained by expert instead of someone just gets started. Or rather,it seems that confusions about the internals should be clarified by expert,rather than studying the code.
After all,the starting point of learning a project is the Doc instead of the code,in my opinon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] RedemptionC commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
RedemptionC commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1006233444
Hi, @zhongjiajie
I've noticed that many versions of 1.3.x Doc are written this way
In fact,I was intending to ask advice on modification so that I can change all of them if my understanding on this modification is true
But somehow it was merged directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1006321814
@RedemptionC If you need help or advice when you create issue or PR, feel free to ping me, I would reply ASAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] SunnyZ-L commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
SunnyZ-L commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1006461712
> Hi, @zhongjiajie Yes,I'd like to help improve the Docs. But as I don't know much about DS internal,I have to learn from the docs(if not the code),during which I did have some questions. For example: 1. [#618 (comment)](https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1005463666) I made this modification to make this sentence sound smoothly,but I don't know if it's the truth,i.e.,is workerServer providing listening servive based on netty? [#618 (comment)](https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1005468955) Though @zhuangchong gave some explanation,it seems that my question isn't answered directly. Maybe it's due to that I'm not familiar with netty and I should learn it,but the reality is that I still don't know whether this modification makes sense. 2. [apache/dolphinscheduler#7835](https://github.com/apache/dolphinscheduler/discussions/7835) 3. [apache/dolphinscheduler#7306](https://github.com/apache/dolphinscheduler/discu
ssions/7306)
>#618 (comment)
I made this modification to make this sentence sound smoothly,but I don't know if it's the truth,i.e.,is workerServer providing listening servive based on netty?
Your modification is correct, the original document should be a clerical error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] RedemptionC commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
RedemptionC commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1006341022
Hi, @zhongjiajie
Yes,I'd like to help improve the Docs.
But as I don't know much about DS internal,I have to learn from the docs(if not the code),during which I did have some questions.
For example:
1.
https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1005463666
I made this modification to make this sentence sound smoothly,but I don't know if it's the truth,i.e.,is workerServer providing listening servive based on netty?
https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1005468955
Though @zhuangchong gave some explanation,it seems that my question isn't answered directly. Maybe it's due to that I'm not familiar with netty and I should learn it,but the reality is that I still don't know whether this modification makes sense.
2. https://github.com/apache/dolphinscheduler/discussions/7835
3. https://github.com/apache/dolphinscheduler/discussions/7306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #618: Fix format and typo in 1.3.9 Doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #618:
URL: https://github.com/apache/dolphinscheduler-website/pull/618#issuecomment-1007119523
Thanks @SunnyZ-L for the clarification. cc @RedemptionC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org