You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/01/10 18:54:09 UTC
Review Request 65077: Added a test to check `wait` of composing c'zer
after recovery.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65077/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
Bugs: MESOS-8391
https://issues.apache.org/jira/browse/MESOS-8391
Repository: mesos
Description
-------
This test verifies that `wait()` called on composing containerizer for
a container that has been recovered, returns a future set to `READY`
iff the container is terminated.
Diffs
-----
src/tests/containerizer/composing_containerizer_tests.cpp 7c22f162b128c3fdf8d4b20cac73fdf442449d79
Diff: https://reviews.apache.org/r/65077/diff/1/
Testing
-------
./src/mesos-tests --gtest_filter=ComposingContainerizerTest.WaitAfterRecovery --gtest_break_on_failure --gtest_repeat=100 --verbose
Thanks,
Andrei Budnik
Re: Review Request 65077: Added a test to check `wait` of composing
c'zer after recovery.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65077/#review195166
-----------------------------------------------------------
FAIL: Mesos failed to build.
Reviews applied: `['65071', '65077']`
Failed command: `cmake.exe D:\DCOS\mesos\mesos -G "Visual Studio 15 2017 Win64" -T host=x64 -DENABLE_LIBEVENT=ON -DHAS_AUTHENTICATION=ON -DENABLE_JAVA=ON -DENABLE_SSL=ON`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65077
Relevant logs:
- [mesos-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65077/logs/mesos-build-cmake-stdout.log):
```
-- The C compiler identification is unknown
-- The CXX compiler identification is unknown
-- Configuring incomplete, errors occurred!
See also "D:/DCOS/mesos/CMakeFiles/CMakeOutput.log".
See also "D:/DCOS/mesos/CMakeFiles/CMakeError.log".
```
- [mesos-build-cmake-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65077/logs/mesos-build-cmake-stderr.log):
```
CMake Error at CMakeLists.txt:25 (project):
No CMAKE_C_COMPILER could be found.
CMake Error at CMakeLists.txt:25 (project):
No CMAKE_CXX_COMPILER could be found.
```
- [mesos-build-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65077/logs/mesos-build-CMakeOutput.log):
```
The system is: Windows - 10.0.16299 - AMD64
```
- [mesos-build-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65077/logs/mesos-build-CMakeError.log):
```
Copyright (C) Microsoft Corporation. All rights reserved.
Build started 1/10/2018 7:00:41 PM.
Project "D:\DCOS\mesos\CMakeFiles\3.9.0\CompilerIdCXX\CompilerIdCXX.vcxproj" on node 1 (default targets).
PrepareForBuild:
Creating directory "Debug\".
Creating directory "Debug\CompilerIdCXX.tlog\".
InitializeBuildStatus:
Creating "Debug\CompilerIdCXX.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /nologo /W0 /WX- /diagnostics:classic /Od /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"Debug\" /Fd"Debug\vc141.pdb" /Gd /TP /errorReport:queue CMakeCXXCompilerId.cpp
CMakeCXXCompilerId.cpp
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:".\CompilerIdCXX.exe" /INCREMENTAL:NO /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /PDB:".\CompilerIdCXX.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:".\CompilerIdCXX.lib" /MACHINE:X64 Debug\CMakeCXXCompilerId.obj
LINK : fatal error LNK1104: cannot open file 'C:\Users\mesos\AppData\Local\Temp\lnk{9E887760-C5FF-4CDD-A63D-FFB69B4B96DF}.tmp' [D:\DCOS\mesos\CMakeFiles\3.9.0\CompilerIdCXX\CompilerIdCXX.vcxproj]
Done Building Project "D:\DCOS\mesos\CMakeFiles\3.9.0\CompilerIdCXX\CompilerIdCXX.vcxproj" (default targets) -- FAILED.
Build FAILED.
"D:\DCOS\mesos\CMakeFiles\3.9.0\CompilerIdCXX\CompilerIdCXX.vcxproj" (default target) (1) ->
(Link target) ->
LINK : fatal error LNK1104: cannot open file 'C:\Users\mesos\AppData\Local\Temp\lnk{9E887760-C5FF-4CDD-A63D-FFB69B4B96DF}.tmp' [D:\DCOS\mesos\CMakeFiles\3.9.0\CompilerIdCXX\CompilerIdCXX.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:00.87
```
- Mesos Reviewbot Windows
On Jan. 10, 2018, 10:54 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65077/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 10:54 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-8391
> https://issues.apache.org/jira/browse/MESOS-8391
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that `wait()` called on composing containerizer for
> a container that has been recovered, returns a future set to `READY`
> iff the container is terminated.
>
>
> Diffs
> -----
>
> src/tests/containerizer/composing_containerizer_tests.cpp 7c22f162b128c3fdf8d4b20cac73fdf442449d79
>
>
> Diff: https://reviews.apache.org/r/65077/diff/1/
>
>
> Testing
> -------
>
> ./src/mesos-tests --gtest_filter=ComposingContainerizerTest.WaitAfterRecovery --gtest_break_on_failure --gtest_repeat=100 --verbose
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 65077: Added a test to check `wait` of composing
c'zer after recovery.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Jan. 11, 2018, 11:07 a.m., Gilbert Song wrote:
> > src/tests/containerizer/composing_containerizer_tests.cpp
> > Lines 363-371 (patched)
> > <https://reviews.apache.org/r/65077/diff/1/?file=1938292#file1938292line363>
> >
> > This part can also passed without recovering above, right?
> >
> > Maybe we do not want to verify the underlying wait() is called or not under the composing containerizer `recover()`. Since this is a regression test, could we have an end-to-end test (restart the agent and kill a task, verify the task with correct status)?
This test won't work without recovering.
I need to clarify that we don't verify here that `wait()` is called. We verify that the future returned by _composing containerizer's_ `wait()` is set to `READY` state when a container is terminated.
We have a lot of containerizer tests that include this test case, but they work against `MesosContainerizer`. We need to parametrize these tests to run them against different containerizers and `ComposingContainerizer` or always run them againg `ComposingContainerizer`.
In any case end-to-end test will be a good addition to this test.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65077/#review195219
-----------------------------------------------------------
On Jan. 10, 2018, 6:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65077/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 6:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-8391
> https://issues.apache.org/jira/browse/MESOS-8391
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that `wait()` called on composing containerizer for
> a container that has been recovered, returns a future set to `READY`
> iff the container is terminated.
>
>
> Diffs
> -----
>
> src/tests/containerizer/composing_containerizer_tests.cpp 7c22f162b128c3fdf8d4b20cac73fdf442449d79
>
>
> Diff: https://reviews.apache.org/r/65077/diff/1/
>
>
> Testing
> -------
>
> ./src/mesos-tests --gtest_filter=ComposingContainerizerTest.WaitAfterRecovery --gtest_break_on_failure --gtest_repeat=100 --verbose
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 65077: Added a test to check `wait` of composing
c'zer after recovery.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65077/#review195219
-----------------------------------------------------------
src/tests/containerizer/composing_containerizer_tests.cpp
Lines 363-371 (patched)
<https://reviews.apache.org/r/65077/#comment274396>
This part can also passed without recovering above, right?
Maybe we do not want to verify the underlying wait() is called or not under the composing containerizer `recover()`. Since this is a regression test, could we have an end-to-end test (restart the agent and kill a task, verify the task with correct status)?
- Gilbert Song
On Jan. 10, 2018, 10:54 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65077/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 10:54 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-8391
> https://issues.apache.org/jira/browse/MESOS-8391
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that `wait()` called on composing containerizer for
> a container that has been recovered, returns a future set to `READY`
> iff the container is terminated.
>
>
> Diffs
> -----
>
> src/tests/containerizer/composing_containerizer_tests.cpp 7c22f162b128c3fdf8d4b20cac73fdf442449d79
>
>
> Diff: https://reviews.apache.org/r/65077/diff/1/
>
>
> Testing
> -------
>
> ./src/mesos-tests --gtest_filter=ComposingContainerizerTest.WaitAfterRecovery --gtest_break_on_failure --gtest_repeat=100 --verbose
>
>
> Thanks,
>
> Andrei Budnik
>
>