You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by th...@apache.org on 2019/02/22 07:25:03 UTC
svn commit: r1854115 -
/jackrabbit/oak/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/NRTIndex.java
Author: thomasm
Date: Fri Feb 22 07:25:03 2019
New Revision: 1854115
URL: http://svn.apache.org/viewvc?rev=1854115&view=rev
Log:
OAK-8067 Measure fsync (called when closing the NRT index) and try to reduce disk I/O
Modified:
jackrabbit/oak/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/NRTIndex.java
Modified: jackrabbit/oak/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/NRTIndex.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/NRTIndex.java?rev=1854115&r1=1854114&r2=1854115&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/NRTIndex.java (original)
+++ jackrabbit/oak/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/NRTIndex.java Fri Feb 22 07:25:03 2019
@@ -61,6 +61,7 @@ import static org.apache.jackrabbit.oak.
public class NRTIndex implements Closeable {
private static final boolean REGULAR_CLOSE = Boolean.getBoolean("oak.lucene.nrt.regularClose");
+ private static final boolean RETAIN_DURING_CLOSE = Boolean.getBoolean("oak.lucene.nrt.retainDuringClose");
private static final AtomicInteger COUNTER = new AtomicInteger();
private static final Logger log = LoggerFactory.getLogger(NRTIndex.class);
@@ -208,6 +209,14 @@ public class NRTIndex implements Closeab
if (REGULAR_CLOSE) {
indexWriter.close();
} else {
+ if (RETAIN_DURING_CLOSE) {
+ // retain entries (old style behavior)
+ } else {
+ // delete all documents before closing,
+ // so that closing is faster (less writes are needed)
+ // (we anyway delete the directory after closing)
+ indexWriter.deleteAll();
+ }
// don't merge, as anyway only keep two generations
indexWriter.close(false);
}