[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1344: ftr: triple multi params support

[GitBox <gi...@apache.org>]

LaurenceLiZhixin commented on a change in pull request #1344:
URL: https://github.com/apache/dubbo-go/pull/1344#discussion_r678891263



##########
File path: protocol/dubbo3/dubbo3_protocol.go
##########
@@ -99,18 +99,18 @@ func (dp *DubboProtocol) Export(invoker protocol.Invoker) protocol.Exporter {
 		valueOf := reflect.ValueOf(service)
 		typeOf := valueOf.Type()
 		numField := valueOf.NumMethod()
-		tripleService := &Dubbo3HessianService{proxyImpl: invoker}
+		tripleService := &UnaryService{proxyImpl: invoker}
 		for i := 0; i < numField; i++ {
 			ft := typeOf.Method(i)
 			if ft.Name == "Reference" {
 				continue
 			}
-			// num out is checked in common/rpc_service.go
-			if ft.Type.NumIn() != 3 {

Review comment:
       Thisk Block limit the number of method input params, if not 1 param, it would panic.
   Now, we support any number of param.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org