You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "deardeng (via GitHub)" <gi...@apache.org> on 2024/03/07 06:46:53 UTC

[PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

deardeng opened a new pull request, #31923:
URL: https://github.com/apache/doris/pull/31923

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31923:
URL: https://github.com/apache/doris/pull/31923#issuecomment-1982942876

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 49801 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit bb7e66cb6ad819061b3f0457141aa78c85e121a2, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17694	4353	4316	4316
   q2	2018	151	139	139
   q3	10282	1933	1929	1929
   q4	10369	1236	1321	1236
   q5	8364	4028	3930	3930
   q6	229	119	123	119
   q7	2022	1622	1579	1579
   q8	9564	2695	2725	2695
   q9	13707	10437	10544	10437
   q10	8688	3524	3474	3474
   q11	407	242	239	239
   q12	466	304	300	300
   q13	18329	3987	4046	3987
   q14	356	329	324	324
   q15	512	451	453	451
   q16	686	601	586	586
   q17	1114	909	915	909
   q18	7151	6878	6841	6841
   q19	1665	1511	1538	1511
   q20	494	286	295	286
   q21	4488	4132	4104	4104
   q22	493	409	412	409
   Total cold run time: 119098 ms
   Total hot run time: 49801 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4334	4370	4326	4326
   q2	328	226	221	221
   q3	4205	4211	4196	4196
   q4	2780	2760	2762	2760
   q5	7252	7249	7233	7233
   q6	240	125	122	122
   q7	3262	2864	2880	2864
   q8	4431	4517	4544	4517
   q9	17265	17413	17018	17018
   q10	4352	4303	4336	4303
   q11	748	737	710	710
   q12	1036	858	877	858
   q13	7442	3750	3775	3750
   q14	449	436	440	436
   q15	491	450	444	444
   q16	753	709	693	693
   q17	3848	3840	3950	3840
   q18	8749	8792	8761	8761
   q19	1711	1659	1662	1659
   q20	2413	2200	2137	2137
   q21	8563	8560	8488	8488
   q22	1080	986	989	986
   Total cold run time: 85732 ms
   Total hot run time: 80322 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #31923:
URL: https://github.com/apache/doris/pull/31923


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31923:
URL: https://github.com/apache/doris/pull/31923#issuecomment-1982596414

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31923:
URL: https://github.com/apache/doris/pull/31923#issuecomment-1982997252

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.97 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit bb7e66cb6ad819061b3f0457141aa78c85e121a2, data reload: false
   
   query1	0.03	0.03	0.02
   query2	0.06	0.02	0.02
   query3	0.25	0.04	0.05
   query4	1.84	0.07	0.07
   query5	0.53	0.53	0.52
   query6	1.24	0.63	0.60
   query7	0.01	0.01	0.01
   query8	0.04	0.03	0.02
   query9	0.52	0.48	0.47
   query10	0.54	0.53	0.54
   query11	0.11	0.09	0.09
   query12	0.11	0.10	0.09
   query13	0.62	0.61	0.61
   query14	0.78	0.80	0.78
   query15	0.79	0.76	0.77
   query16	0.37	0.36	0.36
   query17	1.01	1.01	1.00
   query18	0.24	0.25	0.24
   query19	1.95	1.88	1.87
   query20	0.01	0.01	0.01
   query21	15.48	0.57	0.55
   query22	1.66	2.05	1.47
   query23	17.29	1.05	0.84
   query24	4.85	1.32	1.32
   query25	0.42	0.09	0.06
   query26	0.66	0.16	0.17
   query27	0.04	0.04	0.04
   query28	7.68	0.72	0.74
   query29	12.63	2.36	2.39
   query30	0.59	0.54	0.53
   query31	2.83	0.38	0.40
   query32	3.41	0.49	0.50
   query33	3.08	3.04	3.09
   query34	15.27	4.78	4.80
   query35	4.86	4.85	4.86
   query36	1.06	1.02	1.02
   query37	0.06	0.05	0.04
   query38	0.04	0.02	0.02
   query39	0.02	0.02	0.02
   query40	0.16	0.15	0.14
   query41	0.07	0.01	0.01
   query42	0.02	0.01	0.02
   query43	0.02	0.02	0.01
   Total cold run time: 103.25 s
   Total hot run time: 30.97 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31923:
URL: https://github.com/apache/doris/pull/31923#issuecomment-1983007081

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit bb7e66cb6ad819061b3f0457141aa78c85e121a2 with default session variables
   Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       20.7 seconds inserted 10000000 Rows, about 483K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31923:
URL: https://github.com/apache/doris/pull/31923#issuecomment-1982946404

   TeamCity be ut coverage result:
    Function Coverage: 37.81% (8039/21263) 
    Line Coverage: 29.49% (65597/222421)
    Region Coverage: 28.96% (33758/116569)
    Branch Coverage: 24.80% (17319/69846)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/bb7e66cb6ad819061b3f0457141aa78c85e121a2_bb7e66cb6ad819061b3f0457141aa78c85e121a2/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31923:
URL: https://github.com/apache/doris/pull/31923#issuecomment-1982613547

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31923:
URL: https://github.com/apache/doris/pull/31923#issuecomment-1982618425

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31923:
URL: https://github.com/apache/doris/pull/31923#issuecomment-1982618501

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #31923:
URL: https://github.com/apache/doris/pull/31923#issuecomment-1982862776

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](partition) add log when tablet partition id eq 0 (#31796) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31923:
URL: https://github.com/apache/doris/pull/31923#issuecomment-1982980926

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 202063 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit bb7e66cb6ad819061b3f0457141aa78c85e121a2, data reload: false
   
   query1	932	408	380	380
   query2	6534	2251	2242	2242
   query3	6910	195	196	195
   query4	21356	17951	17928	17928
   query5	19712	6506	6540	6506
   query6	301	212	230	212
   query7	4156	304	295	295
   query8	263	270	228	228
   query9	3095	2678	2593	2593
   query10	422	294	300	294
   query11	11284	10602	10708	10602
   query12	122	77	76	76
   query13	5587	648	626	626
   query14	18148	13782	13530	13530
   query15	363	240	249	240
   query16	6432	281	262	262
   query17	1719	1434	872	872
   query18	2321	401	405	401
   query19	195	158	146	146
   query20	77	74	76	74
   query21	186	95	97	95
   query22	5239	5114	5035	5035
   query23	32387	31881	31993	31881
   query24	6817	6469	6489	6469
   query25	520	415	421	415
   query26	515	161	160	160
   query27	1793	294	287	287
   query28	6078	2261	2196	2196
   query29	2917	2791	2715	2715
   query30	245	159	161	159
   query31	880	740	747	740
   query32	59	64	62	62
   query33	389	254	243	243
   query34	867	467	491	467
   query35	1082	991	935	935
   query36	1745	1556	1597	1556
   query37	90	59	62	59
   query38	3127	2951	2925	2925
   query39	1369	1327	1343	1327
   query40	205	94	92	92
   query41	34	32	32	32
   query42	88	77	79	77
   query43	668	594	659	594
   query44	1136	730	723	723
   query45	236	223	226	223
   query46	1236	978	973	973
   query47	1908	1741	1809	1741
   query48	962	671	673	671
   query49	598	378	372	372
   query50	857	577	635	577
   query51	4723	4683	4765	4683
   query52	87	89	83	83
   query53	445	323	319	319
   query54	2661	2427	2483	2427
   query55	84	85	79	79
   query56	230	204	208	204
   query57	1192	1195	1017	1017
   query58	212	200	192	192
   query59	3392	3297	3336	3297
   query60	205	183	193	183
   query61	84	80	80	80
   query62	831	471	513	471
   query63	472	324	320	320
   query64	2477	1458	1338	1338
   query65	3636	3566	3586	3566
   query66	762	369	354	354
   query67	17485	15537	15109	15109
   query68	8355	687	679	679
   query69	561	336	333	333
   query70	2040	1906	1699	1699
   query71	395	306	311	306
   query72	6444	3460	3421	3421
   query73	729	322	331	322
   query74	6265	5841	5891	5841
   query75	5080	3778	3609	3609
   query76	5093	1142	1192	1142
   query77	728	260	243	243
   query78	12464	11494	12502	11494
   query79	9072	647	659	647
   query80	1707	393	381	381
   query81	486	240	230	230
   query82	702	95	94	94
   query83	170	132	129	129
   query84	250	71	69	69
   query85	997	288	271	271
   query86	399	363	391	363
   query87	3200	3031	3038	3031
   query88	4651	2305	2317	2305
   query89	395	327	308	308
   query90	1880	212	200	200
   query91	144	114	111	111
   query92	52	50	51	50
   query93	4046	570	577	570
   query94	750	199	207	199
   query95	1112	1061	1053	1053
   query96	646	331	330	330
   query97	6493	6365	6335	6335
   query98	189	174	175	174
   query99	3061	906	899	899
   Total cold run time: 311696 ms
   Total hot run time: 202063 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org