You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "amotl (via GitHub)" <gi...@apache.org> on 2026/03/03 08:32:19 UTC
[PR] fix(docs): Use modern driver package for CrateDB [superset]
amotl opened a new pull request, #38358:
URL: https://github.com/apache/superset/pull/38358
Dear Superset maintainers,
on the [documentation page about CrateDB](https://superset.apache.org/user-docs/databases/supported/cratedb/), we discovered a possible leftover from the migration from `crate[sqlalchemy]` to `sqlalchemy-cratedb` the other day.
Can you possibly commandeer this patch to be backported to earlier releases of Superset?
With kind regards,
Andreas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #38358: fix(docs): Use modern driver package for CrateDB
URL: https://github.com/apache/superset/pull/38358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "amotl (via GitHub)" <gi...@apache.org>.
amotl commented on code in PR #38358:
URL: https://github.com/apache/superset/pull/38358#discussion_r2896274435
##########
superset/db_engine_specs/crate.py:
##########
@@ -49,7 +49,7 @@ class CrateEngineSpec(BaseEngineSpec):
"drivers": [
{
"name": "crate",
- "pypi_package": "crate[sqlalchemy]",
+ "pypi_package": "sqlalchemy-cratedb",
Review Comment:
Hi @sadpandajoe. Do you think the patch is eligible for merging now? Will you take care about backporting it to earlier active maintenance branches of Apache Superset, for example by using Mergify, or shall we do it manually after this patch got merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "amotl (via GitHub)" <gi...@apache.org>.
amotl commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-4979360030
Hi Evan. Thanks for your swift reply. I can't turn on maintainer commits, and lost access to `crate-workbench`. Yes, please recycle my changes into a different PR. π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-3989505823
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/38358?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.55%. Comparing base ([`1bd0546`](https://app.codecov.io/gh/apache/superset/commit/1bd054684edc8459d0fdc1f7cfa8330f505fbcfd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5d7abd0`](https://app.codecov.io/gh/apache/superset/commit/5d7abd036e8434b7d8a992367f703b9f66b91dd9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:x: Your project check has failed because the head coverage (96.03%) is below the target coverage (100.00%). You can increase the head coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #38358 +/- ##
==========================================
- Coverage 64.29% 54.55% -9.74%
==========================================
Files 1811 2484 +673
Lines 71491 123339 +51848
Branches 22775 28648 +5873
==========================================
+ Hits 45965 67291 +21326
- Misses 25526 55732 +30206
- Partials 0 316 +316
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/38358/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [presto](https://app.codecov.io/gh/apache/superset/pull/38358/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.13% <ΓΈ> (?)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/38358/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.13% <ΓΈ> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/38358?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "amotl (via GitHub)" <gi...@apache.org>.
amotl commented on code in PR #38358:
URL: https://github.com/apache/superset/pull/38358#discussion_r2886262004
##########
superset/db_engine_specs/crate.py:
##########
@@ -49,7 +49,7 @@ class CrateEngineSpec(BaseEngineSpec):
"drivers": [
{
"name": "crate",
- "pypi_package": "crate[sqlalchemy]",
+ "pypi_package": "sqlalchemy-cratedb",
Review Comment:
Sure, thank you. I've just updated the patch as you suggested, cherry-picking the proposal by the code review bot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "amotl (via GitHub)" <gi...@apache.org>.
amotl commented on code in PR #38358:
URL: https://github.com/apache/superset/pull/38358#discussion_r2896274435
##########
superset/db_engine_specs/crate.py:
##########
@@ -49,7 +49,7 @@ class CrateEngineSpec(BaseEngineSpec):
"drivers": [
{
"name": "crate",
- "pypi_package": "crate[sqlalchemy]",
+ "pypi_package": "sqlalchemy-cratedb",
Review Comment:
Hi @sadpandajoe. Do you think the patch is eligible for merging now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-4975312542
Heya... just checking in. Happy to "adopt" the work here on a new PR if time isn't available or flipping on maintainer commits can't be enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-3999599394
<!-- Bito Reply -->
The PR switches the CrateDB PyPI package from 'crate[sqlalchemy]' to 'sqlalchemy-cratedb'. Here's a suggested line item for UPDATING.md to document this change.
**UPDATING.md**
```
- Switched CrateDB PyPI package from `crate[sqlalchemy]` to `sqlalchemy-cratedb`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "amotl (via GitHub)" <gi...@apache.org>.
amotl commented on code in PR #38358:
URL: https://github.com/apache/superset/pull/38358#discussion_r2896274435
##########
superset/db_engine_specs/crate.py:
##########
@@ -49,7 +49,7 @@ class CrateEngineSpec(BaseEngineSpec):
"drivers": [
{
"name": "crate",
- "pypi_package": "crate[sqlalchemy]",
+ "pypi_package": "sqlalchemy-cratedb",
Review Comment:
Hi @sadpandajoe. Do you think the patch is eligible for merging now? Will you take care about backporting it to earlier active maintenance branches of Apache Superset?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-4753276992
@amotl I had a go at rebasing this to clear the conflicts so it could land, but I can't push, looks like "Allow edits by maintainers" isn't enabled on this one. Could you rebase on current `master`?
While I was in there I noticed most of this seems to have landed already (homepage is `cratedb.com`, and `sqlalchemy-cratedb` is in `pypi_packages`), so it might come down to just the driver block's `pypi_package` still being `crate[sqlalchemy]`. Worth a look at whether it's still needed. Just ping me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "amotl (via GitHub)" <gi...@apache.org>.
amotl commented on code in PR #38358:
URL: https://github.com/apache/superset/pull/38358#discussion_r2965860570
##########
superset/db_engine_specs/crate.py:
##########
@@ -49,7 +49,7 @@ class CrateEngineSpec(BaseEngineSpec):
"drivers": [
{
"name": "crate",
- "pypi_package": "crate[sqlalchemy]",
+ "pypi_package": "sqlalchemy-cratedb",
Review Comment:
Hi again. Please let us know if this patch needs any further love. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-4000765180
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #38358:
URL: https://github.com/apache/superset/pull/38358#discussion_r2885560085
##########
superset/db_engine_specs/crate.py:
##########
@@ -49,7 +49,7 @@ class CrateEngineSpec(BaseEngineSpec):
"drivers": [
{
"name": "crate",
- "pypi_package": "crate[sqlalchemy]",
+ "pypi_package": "sqlalchemy-cratedb",
Review Comment:
Can you add a line item in UPDATING.md about switching the pypi package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-3989491856
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "amotl (via GitHub)" <gi...@apache.org>.
amotl commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-4754007735
Hi @rusackas. Thank you for pinging me. @florinutz: Could you take over my branch and bring it to completion according to the suggestions by Evan? π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-4099496974
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-3989498961
### <span aria-hidden="true">β
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">π¨</span> Latest commit | 5d7abd036e8434b7d8a992367f703b9f66b91dd9 |
|<span aria-hidden="true">π</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69a69c94902de80009c4bbd0 |
|<span aria-hidden="true">π</span> Deploy Preview | [https://deploy-preview-38358--superset-docs-preview.netlify.app](https://deploy-preview-38358--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">π±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-38358--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "amotl (via GitHub)" <gi...@apache.org>.
amotl commented on code in PR #38358:
URL: https://github.com/apache/superset/pull/38358#discussion_r2886262004
##########
superset/db_engine_specs/crate.py:
##########
@@ -49,7 +49,7 @@ class CrateEngineSpec(BaseEngineSpec):
"drivers": [
{
"name": "crate",
- "pypi_package": "crate[sqlalchemy]",
+ "pypi_package": "sqlalchemy-cratedb",
Review Comment:
Sure, thank you. I've just updated the patch as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-4998992107
Will do! Thanks for lining up the shot :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): Use modern driver package for CrateDB [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38358:
URL: https://github.com/apache/superset/pull/38358#issuecomment-4999222435
Brought this forward as #42125, closing this one out. Thanks again for flagging it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org