You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by "emmenlau (via GitHub)" <gi...@apache.org> on 2024/08/07 14:49:32 UTC

Re: [PR] Use Bmi2 instrunction to optmize compact protocol int64 code and deco… [thrift]

emmenlau commented on PR #2780:
URL: https://github.com/apache/thrift/pull/2780#issuecomment-2273660788

   This is very interesting. But how to proceed? @Jens-G I guess the tests should cover sufficient checks whether encoded/decoded data is identical with this change? Can we rely that the tests would typically fail if there are relevant differences with this encoding, compared to current thrift?
   
   Otherwise it seems really challenging to build trust here...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org