You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/04/25 16:20:00 UTC
[jira] [Work logged] (BEAM-14363) Kinesis WatermarkParameters builder clobbers values

     [ https://issues.apache.org/jira/browse/BEAM-14363?focusedWorklogId=761886&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761886 ]

ASF GitHub Bot logged work on BEAM-14363:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Apr/22 16:19
            Start Date: 25/Apr/22 16:19
    Worklog Time Spent: 10m 
      Work Description: nickcaballero opened a new pull request, #17458:
URL: https://github.com/apache/beam/pull/17458

   This fixes the `WatermarkParameters` to use `toBuilder()` instead of `builder()`.
   
   ------------------------
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 761886)
    Remaining Estimate: 0h
            Time Spent: 10m

> Kinesis WatermarkParameters builder clobbers values
> ---------------------------------------------------
>
>                 Key: BEAM-14363
>                 URL: https://issues.apache.org/jira/browse/BEAM-14363
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-kinesis
>    Affects Versions: 2.38.0
>            Reporter: Nick Caballero
>            Priority: P2
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The `WatermarkParameters` builder for the Kinesis watermark policy doesn't retain previously set values, which means you can only set either `timestampFn` or `idleDurationThreshold`, but not both.
>  
> The issue is that the exposed methods call `builder()` instead of `toBuilder()`, losing the previous values.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)