[GitHub] [kafka] alok123t commented on a diff in pull request #14162: KAFKA-15312; Force channel before atomic file move

["alok123t (via GitHub)" <gi...@apache.org>]

alok123t commented on code in PR #14162:
URL: https://github.com/apache/kafka/pull/14162#discussion_r1286557850


##########
raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotWriter.java:
##########
@@ -112,6 +112,9 @@ public void freeze() {
             checkIfFrozen("Freeze");
 
             frozenSize = channel.size();
+            // force the channel to write to the file system before closing, this guarantees that the file has the data
+            // on disk before preforming the atomic file move

Review Comment:
   typo: performing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org