You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2022/09/14 20:25:00 UTC

[jira] [Commented] (MSHARED-1143) Remove e.getMessage() duplication when e is passed as object

    [ https://issues.apache.org/jira/browse/MSHARED-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604959#comment-17604959 ] 

Hudson commented on MSHARED-1143:
---------------------------------

Build succeeded in Jenkins: Maven » Maven TLP » maven-shared-io » master #11

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-shared-io/job/master/11/

> Remove e.getMessage() duplication when e is passed as object
> ------------------------------------------------------------
>
>                 Key: MSHARED-1143
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1143
>             Project: Maven Shared Components
>          Issue Type: Task
>          Components: maven-shared-io
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>              Labels: up-for-grabs
>             Fix For: maven-shared-io-3.0.1
>
>
> In many spots this is code:
> {noformat}
> throw new Exception( "Failed to run Maven: " + e.getMessage(), e ); {noformat}
> {{e.getMessage()}} is redundant because {{e}} is already passed to the new exception. It will duplicate the message. Zero benefit. We shall remove them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)