You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dan Fabulich (JIRA)" <ji...@codehaus.org> on 2008/02/08 03:01:28 UTC

[jira] Closed: (SUREFIRE-451) ManifestJarWriter should use java.util.jar.Manifest

     [ http://jira.codehaus.org/browse/SUREFIRE-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Fabulich closed SUREFIRE-451.
---------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.x)
                   2.4.2

Fixed in revision 619732, because some users reported getting "Failed to load Main-Class manifest attribute" errors until they extracted the manifest, re-processed it and re-packed it.

http://www.nabble.com/-ANN--Maven-Surefire-Plugin-2.4.1-for-Maven-2-Released-td15307389s177.html

> ManifestJarWriter should use java.util.jar.Manifest
> ---------------------------------------------------
>
>                 Key: SUREFIRE-451
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-451
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: process forking
>            Reporter: Dan Fabulich
>             Fix For: 2.4.2
>
>
> ManifestJarWriter manages writing the manifest by hand, including wrapping lines, etc. etc.  This code was copied from plexus-archiver when we stopped depending on plexus-archiver.
> But AFAIK there's no reason to do that by hand; java.util.jar.Manifest can take care of all of that for us.  Still, it's creepy that they did all of that work, so maybe there was a good reason for it...?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira