You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/09 13:03:09 UTC
[GitHub] [rocketmq-dashboard] Charmot opened a new pull request, #101: Rocketmq-connect page added
Charmot opened a new pull request, #101:
URL: https://github.com/apache/rocketmq-dashboard/pull/101
## What is the purpose of the change
#https://github.com/apache/rocketmq-connect/issues/181
## Brief changelog
Added rocketmq-connect page.
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] codecov-commenter commented on pull request #101: Rocketmq-connect page added
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #101:
URL: https://github.com/apache/rocketmq-dashboard/pull/101#issuecomment-1195469817
# [Codecov](https://codecov.io/gh/apache/rocketmq-dashboard/pull/101?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#101](https://codecov.io/gh/apache/rocketmq-dashboard/pull/101?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd159cd) into [master](https://codecov.io/gh/apache/rocketmq-dashboard/commit/63d9da7429177914b73c077da807506240a96ef4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (63d9da7) will **decrease** coverage by `5.77%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #101 +/- ##
============================================
- Coverage 76.92% 71.15% -5.78%
Complexity 822 822
============================================
Files 91 97 +6
Lines 2847 3078 +231
Branches 282 292 +10
============================================
Hits 2190 2190
- Misses 500 731 +231
Partials 157 157
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-dashboard/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../dashboard/config/AuthWebMVCConfigurerAdapter.java](https://codecov.io/gh/apache/rocketmq-dashboard/pull/101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2Rhc2hib2FyZC9jb25maWcvQXV0aFdlYk1WQ0NvbmZpZ3VyZXJBZGFwdGVyLmphdmE=) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...cketmq/dashboard/controller/ConnectController.java](https://codecov.io/gh/apache/rocketmq-dashboard/pull/101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2Rhc2hib2FyZC9jb250cm9sbGVyL0Nvbm5lY3RDb250cm9sbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ketmq/dashboard/model/connect/WorkerConnector.java](https://codecov.io/gh/apache/rocketmq-dashboard/pull/101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2Rhc2hib2FyZC9tb2RlbC9jb25uZWN0L1dvcmtlckNvbm5lY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/rocketmq/dashboard/model/connect/WorkerInfo.java](https://codecov.io/gh/apache/rocketmq-dashboard/pull/101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2Rhc2hib2FyZC9tb2RlbC9jb25uZWN0L1dvcmtlckluZm8uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/rocketmq/dashboard/model/connect/WorkerTask.java](https://codecov.io/gh/apache/rocketmq-dashboard/pull/101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2Rhc2hib2FyZC9tb2RlbC9jb25uZWN0L1dvcmtlclRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tmq/dashboard/service/impl/ConnectServiceImpl.java](https://codecov.io/gh/apache/rocketmq-dashboard/pull/101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2Rhc2hib2FyZC9zZXJ2aWNlL2ltcGwvQ29ubmVjdFNlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pache/rocketmq/dashboard/util/HttpRequestUtil.java](https://codecov.io/gh/apache/rocketmq-dashboard/pull/101/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2Rhc2hib2FyZC91dGlsL0h0dHBSZXF1ZXN0VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org