You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/08/02 00:59:17 UTC
Review Request 61368: Minor clean up: Pulled out the reference to
`TaskInfo`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61368/
-----------------------------------------------------------
Review request for mesos and Jiang Yan Xu.
Bugs: MESOS-7821
https://issues.apache.org/jira/browse/MESOS-7821
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/master.cpp 43cb6977ca58dce1808e4bdb2d109d549622beb9
Diff: https://reviews.apache.org/r/61368/diff/1/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 61368: Minor clean up: Pulled out the reference to
`TaskInfo`.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61368/#review181931
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 4808-4810 (original), 4809-4811 (patched)
<https://reviews.apache.org/r/61368/#comment257755>
4 space indentation?
- Jiang Yan Xu
On Aug. 1, 2017, 5:59 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61368/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:59 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-7821
> https://issues.apache.org/jira/browse/MESOS-7821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 43cb6977ca58dce1808e4bdb2d109d549622beb9
>
>
> Diff: https://reviews.apache.org/r/61368/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 61368: Minor clean up: Pulled out the reference to
`TaskInfo`.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61368/#review181929
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On Aug. 1, 2017, 5:59 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61368/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:59 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-7821
> https://issues.apache.org/jira/browse/MESOS-7821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 43cb6977ca58dce1808e4bdb2d109d549622beb9
>
>
> Diff: https://reviews.apache.org/r/61368/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>