You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Ian Luo <ia...@gmail.com> on 2018/11/06 06:59:30 UTC
[DISCUSS] solution for issue 2489
Hi Folks,
Today I take a closer look into issue 2489 [1], and the original pull
request [2] intended to fix it. After examined the code, I think the
proposed pull request is incomplete, therefore I come up with a different
solution [3].
@jsen-joker, @zhonhaishang, @chkckenlj, If you happen to read this email,
pls. take a look and give me your feedback. Right now I request @checkenlj
to review on GitHub.
Thanks,
-Ian.
1. https://github.com/apache/incubator-dubbo/issues/2489
2. https://github.com/apache/incubator-dubbo/pull/2527
3. https://github.com/apache/incubator-dubbo/pull/2739
Re: [DISCUSS] solution for issue 2489
Posted by Ian Luo <ia...@gmail.com>.
Thanks :) I will follow up with cross referencing those two pages Jun
mentioned in the thread.
-Ian.
On Wed, Nov 7, 2018 at 4:21 PM yuhang xiu <ca...@gmail.com> wrote:
> Hi, @jsen-joker, @zhonhaishang
> Since the pr has been merged, I will close the related issue[1] and the
> same pr[2].
>
> [1]https://github.com/apache/incubator-dubbo/issues/2489
> [2]https://github.com/apache/incubator-dubbo/pull/2527
>
> Ian Luo <ia...@gmail.com> 于2018年11月7日周三 下午2:37写道：
>
> > >
> > > Can we simply merge this two pages?
> >
> >
> > I think we cannot merge these two pages. Since page "service downgrade"
> [1]
> > is about how to govern mock service for one particular service, but page
> > "local mock" [2] is for mock configuration. But I think it is a good idea
> > to cross reference each other.
> >
> > BTW, for the page "local mock", it is up to date since I've updated it
> > yesterday :)
> >
> > Regards,
> > -Ian.
> >
> > 1. http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html
> > 2. http://dubbo.apache.org/zh-cn/docs/user/demos/local-mock.html
> >
> > On Wed, Nov 7, 2018 at 2:30 PM jun liu <ke...@gmail.com> wrote:
> >
> > > > I think we should enhance the document for ‘mock’, even I myself
> don’t
> > > know there’re so many different ways to enable mock.
> > > > http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html
> <
> > > http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html>
> > >
> > > I find this page in the doc:
> > > http://dubbo.apache.org/zh-cn/docs/user/demos/local-mock.html <
> > > http://dubbo.apache.org/zh-cn/docs/user/demos/local-mock.html>
> > >
> > > Can we simply merge this two pages?
> > >
> > > Best regards,
> > > Jun
> > >
> > > > On Nov 7, 2018, at 11:51 AM, jun liu <ke...@gmail.com> wrote:
> > > >
> > > > I think it’s good to go with the patch #2742. Now the xml can give a
> > > equivalent support compared with the way using the override url
> protocol.
> > > >
> > > > I think we should enhance the document for ‘mock’, even I myself
> don’t
> > > know there’re so many different ways to enable mock.
> > > > http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html
> <
> > > http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html>
> > > >
> > > > Best regards,
> > > > Jun
> > > >
> > > >> On Nov 6, 2018, at 2:59 PM, Ian Luo <ian.luo@gmail.com <mailto:
> > > ian.luo@gmail.com>> wrote:
> > > >>
> > > >> Hi Folks,
> > > >>
> > > >> Today I take a closer look into issue 2489 [1], and the original
> pull
> > > >> request [2] intended to fix it. After examined the code, I think the
> > > >> proposed pull request is incomplete, therefore I come up with a
> > > different
> > > >> solution [3].
> > > >>
> > > >> @jsen-joker, @zhonhaishang, @chkckenlj, If you happen to read this
> > > email,
> > > >> pls. take a look and give me your feedback. Right now I request
> > > @checkenlj
> > > >> to review on GitHub.
> > > >>
> > > >> Thanks,
> > > >> -Ian.
> > > >>
> > > >> 1. https://github.com/apache/incubator-dubbo/issues/2489 <
> > > https://github.com/apache/incubator-dubbo/issues/2489>
> > > >> 2. https://github.com/apache/incubator-dubbo/pull/2527 <
> > > https://github.com/apache/incubator-dubbo/pull/2527>
> > > >> 3. https://github.com/apache/incubator-dubbo/pull/2739 <
> > > https://github.com/apache/incubator-dubbo/pull/2739>
> > > >
> > >
> > >
> >
>
Re: [DISCUSS] solution for issue 2489
Posted by yuhang xiu <ca...@gmail.com>.
Hi, @jsen-joker, @zhonhaishang
Since the pr has been merged, I will close the related issue[1] and the
same pr[2].
[1]https://github.com/apache/incubator-dubbo/issues/2489
[2]https://github.com/apache/incubator-dubbo/pull/2527
Ian Luo <ia...@gmail.com> 于2018年11月7日周三 下午2:37写道：
> >
> > Can we simply merge this two pages?
>
>
> I think we cannot merge these two pages. Since page "service downgrade" [1]
> is about how to govern mock service for one particular service, but page
> "local mock" [2] is for mock configuration. But I think it is a good idea
> to cross reference each other.
>
> BTW, for the page "local mock", it is up to date since I've updated it
> yesterday :)
>
> Regards,
> -Ian.
>
> 1. http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html
> 2. http://dubbo.apache.org/zh-cn/docs/user/demos/local-mock.html
>
> On Wed, Nov 7, 2018 at 2:30 PM jun liu <ke...@gmail.com> wrote:
>
> > > I think we should enhance the document for ‘mock’, even I myself don’t
> > know there’re so many different ways to enable mock.
> > > http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html <
> > http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html>
> >
> > I find this page in the doc:
> > http://dubbo.apache.org/zh-cn/docs/user/demos/local-mock.html <
> > http://dubbo.apache.org/zh-cn/docs/user/demos/local-mock.html>
> >
> > Can we simply merge this two pages?
> >
> > Best regards,
> > Jun
> >
> > > On Nov 7, 2018, at 11:51 AM, jun liu <ke...@gmail.com> wrote:
> > >
> > > I think it’s good to go with the patch #2742. Now the xml can give a
> > equivalent support compared with the way using the override url protocol.
> > >
> > > I think we should enhance the document for ‘mock’, even I myself don’t
> > know there’re so many different ways to enable mock.
> > > http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html <
> > http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html>
> > >
> > > Best regards,
> > > Jun
> > >
> > >> On Nov 6, 2018, at 2:59 PM, Ian Luo <ian.luo@gmail.com <mailto:
> > ian.luo@gmail.com>> wrote:
> > >>
> > >> Hi Folks,
> > >>
> > >> Today I take a closer look into issue 2489 [1], and the original pull
> > >> request [2] intended to fix it. After examined the code, I think the
> > >> proposed pull request is incomplete, therefore I come up with a
> > different
> > >> solution [3].
> > >>
> > >> @jsen-joker, @zhonhaishang, @chkckenlj, If you happen to read this
> > email,
> > >> pls. take a look and give me your feedback. Right now I request
> > @checkenlj
> > >> to review on GitHub.
> > >>
> > >> Thanks,
> > >> -Ian.
> > >>
> > >> 1. https://github.com/apache/incubator-dubbo/issues/2489 <
> > https://github.com/apache/incubator-dubbo/issues/2489>
> > >> 2. https://github.com/apache/incubator-dubbo/pull/2527 <
> > https://github.com/apache/incubator-dubbo/pull/2527>
> > >> 3. https://github.com/apache/incubator-dubbo/pull/2739 <
> > https://github.com/apache/incubator-dubbo/pull/2739>
> > >
> >
> >
>
Re: [DISCUSS] solution for issue 2489
Posted by Ian Luo <ia...@gmail.com>.
>
> Can we simply merge this two pages?
I think we cannot merge these two pages. Since page "service downgrade" [1]
is about how to govern mock service for one particular service, but page
"local mock" [2] is for mock configuration. But I think it is a good idea
to cross reference each other.
BTW, for the page "local mock", it is up to date since I've updated it
yesterday :)
Regards,
-Ian.
1. http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html
2. http://dubbo.apache.org/zh-cn/docs/user/demos/local-mock.html
On Wed, Nov 7, 2018 at 2:30 PM jun liu <ke...@gmail.com> wrote:
> > I think we should enhance the document for ‘mock’, even I myself don’t
> know there’re so many different ways to enable mock.
> > http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html <
> http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html>
>
> I find this page in the doc:
> http://dubbo.apache.org/zh-cn/docs/user/demos/local-mock.html <
> http://dubbo.apache.org/zh-cn/docs/user/demos/local-mock.html>
>
> Can we simply merge this two pages?
>
> Best regards,
> Jun
>
> > On Nov 7, 2018, at 11:51 AM, jun liu <ke...@gmail.com> wrote:
> >
> > I think it’s good to go with the patch #2742. Now the xml can give a
> equivalent support compared with the way using the override url protocol.
> >
> > I think we should enhance the document for ‘mock’, even I myself don’t
> know there’re so many different ways to enable mock.
> > http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html <
> http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html>
> >
> > Best regards,
> > Jun
> >
> >> On Nov 6, 2018, at 2:59 PM, Ian Luo <ian.luo@gmail.com <mailto:
> ian.luo@gmail.com>> wrote:
> >>
> >> Hi Folks,
> >>
> >> Today I take a closer look into issue 2489 [1], and the original pull
> >> request [2] intended to fix it. After examined the code, I think the
> >> proposed pull request is incomplete, therefore I come up with a
> different
> >> solution [3].
> >>
> >> @jsen-joker, @zhonhaishang, @chkckenlj, If you happen to read this
> email,
> >> pls. take a look and give me your feedback. Right now I request
> @checkenlj
> >> to review on GitHub.
> >>
> >> Thanks,
> >> -Ian.
> >>
> >> 1. https://github.com/apache/incubator-dubbo/issues/2489 <
> https://github.com/apache/incubator-dubbo/issues/2489>
> >> 2. https://github.com/apache/incubator-dubbo/pull/2527 <
> https://github.com/apache/incubator-dubbo/pull/2527>
> >> 3. https://github.com/apache/incubator-dubbo/pull/2739 <
> https://github.com/apache/incubator-dubbo/pull/2739>
> >
>
>
Re: [DISCUSS] solution for issue 2489
Posted by jun liu <ke...@gmail.com>.
> I think we should enhance the document for ‘mock’, even I myself don’t know there’re so many different ways to enable mock.
> http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html <http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html>
I find this page in the doc:
http://dubbo.apache.org/zh-cn/docs/user/demos/local-mock.html <http://dubbo.apache.org/zh-cn/docs/user/demos/local-mock.html>
Can we simply merge this two pages?
Best regards,
Jun
> On Nov 7, 2018, at 11:51 AM, jun liu <ke...@gmail.com> wrote:
>
> I think it’s good to go with the patch #2742. Now the xml can give a equivalent support compared with the way using the override url protocol.
>
> I think we should enhance the document for ‘mock’, even I myself don’t know there’re so many different ways to enable mock.
> http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html <http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html>
>
> Best regards,
> Jun
>
>> On Nov 6, 2018, at 2:59 PM, Ian Luo <ian.luo@gmail.com <ma...@gmail.com>> wrote:
>>
>> Hi Folks,
>>
>> Today I take a closer look into issue 2489 [1], and the original pull
>> request [2] intended to fix it. After examined the code, I think the
>> proposed pull request is incomplete, therefore I come up with a different
>> solution [3].
>>
>> @jsen-joker, @zhonhaishang, @chkckenlj, If you happen to read this email,
>> pls. take a look and give me your feedback. Right now I request @checkenlj
>> to review on GitHub.
>>
>> Thanks,
>> -Ian.
>>
>> 1. https://github.com/apache/incubator-dubbo/issues/2489 <https://github.com/apache/incubator-dubbo/issues/2489>
>> 2. https://github.com/apache/incubator-dubbo/pull/2527 <https://github.com/apache/incubator-dubbo/pull/2527>
>> 3. https://github.com/apache/incubator-dubbo/pull/2739 <https://github.com/apache/incubator-dubbo/pull/2739>
>
Re: [DISCUSS] solution for issue 2489
Posted by jun liu <ke...@gmail.com>.
I think it’s good to go with the patch #2742. Now the xml can give a equivalent support compared with the way using the override url protocol.
I think we should enhance the document for ‘mock’, even I myself don’t know there’re so many different ways to enable mock.
http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html <http://dubbo.apache.org/zh-cn/docs/user/demos/service-downgrade.html>
Best regards,
Jun
> On Nov 6, 2018, at 2:59 PM, Ian Luo <ia...@gmail.com> wrote:
>
> Hi Folks,
>
> Today I take a closer look into issue 2489 [1], and the original pull
> request [2] intended to fix it. After examined the code, I think the
> proposed pull request is incomplete, therefore I come up with a different
> solution [3].
>
> @jsen-joker, @zhonhaishang, @chkckenlj, If you happen to read this email,
> pls. take a look and give me your feedback. Right now I request @checkenlj
> to review on GitHub.
>
> Thanks,
> -Ian.
>
> 1. https://github.com/apache/incubator-dubbo/issues/2489
> 2. https://github.com/apache/incubator-dubbo/pull/2527
> 3. https://github.com/apache/incubator-dubbo/pull/2739
Re: [DISCUSS] solution for issue 2489
Posted by jun liu <ke...@gmail.com>.
I am working on it now.
Best regards,
Jun
> On Nov 6, 2018, at 2:59 PM, Ian Luo <ia...@gmail.com> wrote:
>
> Hi Folks,
>
> Today I take a closer look into issue 2489 [1], and the original pull
> request [2] intended to fix it. After examined the code, I think the
> proposed pull request is incomplete, therefore I come up with a different
> solution [3].
>
> @jsen-joker, @zhonhaishang, @chkckenlj, If you happen to read this email,
> pls. take a look and give me your feedback. Right now I request @checkenlj
> to review on GitHub.
>
> Thanks,
> -Ian.
>
> 1. https://github.com/apache/incubator-dubbo/issues/2489
> 2. https://github.com/apache/incubator-dubbo/pull/2527
> 3. https://github.com/apache/incubator-dubbo/pull/2739