[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #10483: [Improvement][Api] Interface and entity optimization to improve code scalability.

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #10483:
URL: https://github.com/apache/dolphinscheduler/pull/10483#discussion_r899724706


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java:
##########
@@ -279,7 +279,7 @@ public Map<String, Object> createProcessDefinition(User loginUser,
         return createDagDefine(loginUser, taskRelationList, processDefinition, taskDefinitionLogs, otherParamsJson);
     }
 
-    private Map<String, Object> createDagDefine(User loginUser,
+    public Map<String, Object> createDagDefine(User loginUser,

Review Comment:
   Do we need to add `createDagDefine` at `ProcessDefinitionService` interface?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org