[GitHub] [airflow] ashb commented on a change in pull request #13392: Add upgrade check option to list checks

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r552247692



##########
File path: tests/upgrade/rules/test_base_rule.py
##########
@@ -25,3 +25,20 @@ def test_rules_are_registered(self):
         rule_classes = get_rules()
         assert BaseRule not in rule_classes
         assert ConnTypeIsNotNullableRule in rule_classes
+
+    def test_rules_are_ordered(self):
+        rule_classes = get_rules()
+        from airflow.upgrade.rules.aaa_airflow_version_check import VersionCheckRule
+        from airflow.upgrade.rules.conn_id_is_unique import UniqueConnIdRule
+        from airflow.upgrade.rules.no_additional_args_in_operators import (
+            NoAdditionalArgsInOperatorsRule,
+        )
+
+        # Version check should still be first
+        assert rule_classes[0] == VersionCheckRule
+        print(rule_classes)

Review comment:
       ```suggestion
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org