[GitHub] [commons-email] garydgregory commented on a diff in pull request #101: 3 mutators

[GitBox <gi...@apache.org>]

garydgregory commented on code in PR #101:
URL: https://github.com/apache/commons-email/pull/101#discussion_r989513012


##########
src/main/java/org/apache/commons/mail/util/MimeMessageParser.java:
##########
@@ -205,7 +199,7 @@ protected void parse(final Multipart parent, final MimePart part)
                 {
                     final String cid = stripContentId(part.getContentID());
                     final DataSource ds = createDataSource(parent, part);
-                    if (cid != null)
+                    if (true)

Review Comment:
   Uh?



##########
src/test/java/org/apache/commons/mail/util/MimeMessageParserTest.java:
##########
@@ -159,7 +159,7 @@ public void testParseHtmlEmailWithAttachmentAndEncodedFilename() throws Exceptio
      *
      * @throws Exception the test failed
      */
-    @Test
+    //@Test

Review Comment:
   Why are you disabling this test?



##########
src/main/java/org/apache/commons/mail/util/MimeMessageParser.java:
##########
@@ -133,7 +127,7 @@ public List<javax.mail.Address> getBcc() throws Exception
     public String getFrom() throws Exception
     {
         final javax.mail.Address[] addresses = this.mimeMessage.getFrom();
-        if (addresses == null || addresses.length == 0)
+        if (addresses == null)

Review Comment:
   Why?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org