You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2009/01/23 23:11:59 UTC
[jira] Created: (HADOOP-5120) UpgradeManagerNamenode and
UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
UpgradeManagerNamenode and UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
----------------------------------------------------------------------------------------------
Key: HADOOP-5120
URL: https://issues.apache.org/jira/browse/HADOOP-5120
Project: Hadoop Core
Issue Type: Sub-task
Components: dfs
Reporter: Tsz Wo (Nicholas), SZE
UpgradeManagerNamenode and UpgradeObjectNamenode should not access the namespace by the static method FSNamesystem.getFSNamesystem()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5120) UpgradeManagerNamenode and
UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675919#action_12675919 ]
Hudson commented on HADOOP-5120:
--------------------------------
Integrated in Hadoop-trunk #763 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/763/])
> UpgradeManagerNamenode and UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5120
> URL: https://issues.apache.org/jira/browse/HADOOP-5120
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.21.0
>
> Attachments: 5120_20090202.patch
>
>
> UpgradeManagerNamenode and UpgradeObjectNamenode should not access the namespace by the static method FSNamesystem.getFSNamesystem()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5120) UpgradeManagerNamenode and
UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5120:
-------------------------------------------
Attachment: 5120_20090202.patch
5120_20090202.patch: removed the uses of FSNamesystem.getFSNamesystem()
> UpgradeManagerNamenode and UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5120
> URL: https://issues.apache.org/jira/browse/HADOOP-5120
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 5120_20090202.patch
>
>
> UpgradeManagerNamenode and UpgradeObjectNamenode should not access the namespace by the static method FSNamesystem.getFSNamesystem()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5120) UpgradeManagerNamenode and
UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675439#action_12675439 ]
Konstantin Shvachko commented on HADOOP-5120:
---------------------------------------------
+1.
A wish for future changes in this direction. In many cases it is not necessary to pass the whole FSNamesystem class reference. If only FSImage of FSDirectory is necessary please make constructors take exactly that. Like here, you could have moved a call to FSNamesystem.leaveSafeMode() up to FSNamesystem.processDistributedUpgradeCommand, and then UpgradeManagerNamenode would need only FSImage.
I am trying to prevent mistakes which break the synchronization order. They are very easy make if you have a direct reference to FSNamesystem.
> UpgradeManagerNamenode and UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5120
> URL: https://issues.apache.org/jira/browse/HADOOP-5120
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.21.0
>
> Attachments: 5120_20090202.patch
>
>
> UpgradeManagerNamenode and UpgradeObjectNamenode should not access the namespace by the static method FSNamesystem.getFSNamesystem()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5120) UpgradeManagerNamenode and
UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674848#action_12674848 ]
Raghu Angadi commented on HADOOP-5120:
--------------------------------------
+1.
This removes a main()... which is unrelated. To keep it or not is up to you. Konstantin might have used it sometime back.
> UpgradeManagerNamenode and UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5120
> URL: https://issues.apache.org/jira/browse/HADOOP-5120
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 5120_20090202.patch
>
>
> UpgradeManagerNamenode and UpgradeObjectNamenode should not access the namespace by the static method FSNamesystem.getFSNamesystem()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5120) UpgradeManagerNamenode and
UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5120:
-------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
The failed test is not related. I committed this.
> UpgradeManagerNamenode and UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5120
> URL: https://issues.apache.org/jira/browse/HADOOP-5120
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.21.0
>
> Attachments: 5120_20090202.patch
>
>
> UpgradeManagerNamenode and UpgradeObjectNamenode should not access the namespace by the static method FSNamesystem.getFSNamesystem()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5120) UpgradeManagerNamenode and
UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675282#action_12675282 ]
Hadoop QA commented on HADOOP-5120:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12399309/5120_20090202.patch
against trunk revision 746010.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3886/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3886/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3886/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3886/console
This message is automatically generated.
> UpgradeManagerNamenode and UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5120
> URL: https://issues.apache.org/jira/browse/HADOOP-5120
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.21.0
>
> Attachments: 5120_20090202.patch
>
>
> UpgradeManagerNamenode and UpgradeObjectNamenode should not access the namespace by the static method FSNamesystem.getFSNamesystem()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5120) UpgradeManagerNamenode and
UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5120:
-------------------------------------------
Fix Version/s: 0.21.0
Assignee: Tsz Wo (Nicholas), SZE
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
Tested locally, submitting ...
> UpgradeManagerNamenode and UpgradeObjectNamenode should not use FSNamesystem.getFSNamesystem()
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5120
> URL: https://issues.apache.org/jira/browse/HADOOP-5120
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.21.0
>
> Attachments: 5120_20090202.patch
>
>
> UpgradeManagerNamenode and UpgradeObjectNamenode should not access the namespace by the static method FSNamesystem.getFSNamesystem()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.