You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xushiyan (via GitHub)" <gi...@apache.org> on 2023/12/12 22:36:41 UTC

[PR] [HUDI-7226] Fix clean-by-hour policy for race condition [hudi]

xushiyan opened a new pull request, #10321:
URL: https://github.com/apache/hudi/pull/10321

   ### Change Logs
   
   `lastVersionBeforeEarliestCommitToRetain` is not honored by `KEEP_LATEST_BY_HOURS` policy. This essentially makes cleaner to remove an eligible file slice when it becomes non-latest. This could fail long-running queries in a race condition:
   
   1. timeline contains a t0.deltacommit (not cleaned because it's latest)
   2. a snapshot query starts and running
   3. compaction runs and creates t1.commit
   4. cleaner runs and remove t0 (because now t1.commit is the latest)
   5. the query failed due to a log file belongs to t0.deltacommit is not found
   
   ### Impact
   
   Make cleaner logic more robust when use clean by hour policy.
   
   ### Risk level
   
   Low.
   
   ### Documentation Update
   
   NA
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [HUDI-7226] Fix clean-by-hour policy for race condition [hudi]

Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on PR #10321:
URL: https://github.com/apache/hudi/pull/10321#issuecomment-1852932475

   This is covered in this PR https://github.com/apache/hudi/pull/10307 which also adds test cases


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [HUDI-7226] Fix clean-by-hour policy for race condition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10321:
URL: https://github.com/apache/hudi/pull/10321#issuecomment-1852938645

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "beb7d827c906c84624b1905000401d4494e622e6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21479",
       "triggerID" : "beb7d827c906c84624b1905000401d4494e622e6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * beb7d827c906c84624b1905000401d4494e622e6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21479) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [HUDI-7226] Fix clean-by-hour policy for race condition [hudi]

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan closed pull request #10321: [HUDI-7226] Fix clean-by-hour policy for race condition
URL: https://github.com/apache/hudi/pull/10321


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [HUDI-7226] Fix clean-by-hour policy for race condition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10321:
URL: https://github.com/apache/hudi/pull/10321#issuecomment-1852931090

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "beb7d827c906c84624b1905000401d4494e622e6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "beb7d827c906c84624b1905000401d4494e622e6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * beb7d827c906c84624b1905000401d4494e622e6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [HUDI-7226] Fix clean-by-hour policy for race condition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10321:
URL: https://github.com/apache/hudi/pull/10321#issuecomment-1853083718

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "beb7d827c906c84624b1905000401d4494e622e6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21479",
       "triggerID" : "beb7d827c906c84624b1905000401d4494e622e6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * beb7d827c906c84624b1905000401d4494e622e6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21479) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org