[GitHub] spark pull request: [SPARK-1442][SQL] Window Function Support for ...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5604#discussion_r55140466
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala ---
    @@ -195,9 +202,28 @@ case class Aggregate(
         child: LogicalPlan)
       extends UnaryNode {
     
    +  override lazy val resolved: Boolean = {
    +    val hasWindowExpressions = aggregateExpressions.exists ( _.collect {
    +        case window: WindowExpression => window
    +      }.nonEmpty
    +    )
    +
    +    !expressions.exists(!_.resolved) && childrenResolved && !hasWindowExpressions
    +  }
    +
       override def output: Seq[Attribute] = aggregateExpressions.map(_.toAttribute)
     }
     
    +case class Window(
    +    projectList: Seq[Attribute],
    --- End diff --
    
    Why we need a `projectList` in `Window`? Isn't it always equal to `child.output`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org