You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/16 12:16:53 UTC
[GitHub] [pulsar] xche opened a new pull request #8577: [Functions] Delete the message listener and add a thread to get the m…
xche opened a new pull request #8577:
URL: https://github.com/apache/pulsar/pull/8577
…essage from the consumer (#8575)
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
The reason for this problem is that there is only one PulsarClient in a functionWorker instance, and the number of externalExecutorProvider thread pools in PulsarClient is 1, so all consumers share the same listener executor. Therefore, when one or more tasks stoped, the listener executor will be blocked, and finally other tasks will stop consuming data.
### Modifications
Remove messageListener, add add a thread to get the message from the consumer .
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on a change in pull request #8577: [Functions] Delete the message listener and add a thread to get the message from the consumer
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #8577:
URL: https://github.com/apache/pulsar/pull/8577#discussion_r524475510
##########
File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSource.java
##########
@@ -66,7 +71,7 @@ public void open(Map<String, Object> config, SourceContext sourceContext) throws
// Setup schemas
log.info("Opening pulsar source with config: {}", pulsarSourceConfig);
Map<String, ConsumerConfig<T>> configs = setupConsumerConfigs();
-
+ consumerExecutor = Executors.newFixedThreadPool(configs.size(),new DefaultThreadFactory(String.format("%s-%s",sourceContext.getSourceName(), sourceContext.getInstanceId())));
Review comment:
why the pool size is `configs.size`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xche commented on a change in pull request #8577: [Functions] Delete the message listener and add a thread to get the message from the consumer
Posted by GitBox <gi...@apache.org>.
xche commented on a change in pull request #8577:
URL: https://github.com/apache/pulsar/pull/8577#discussion_r524832000
##########
File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSource.java
##########
@@ -66,7 +71,7 @@ public void open(Map<String, Object> config, SourceContext sourceContext) throws
// Setup schemas
log.info("Opening pulsar source with config: {}", pulsarSourceConfig);
Map<String, ConsumerConfig<T>> configs = setupConsumerConfigs();
-
+ consumerExecutor = Executors.newFixedThreadPool(configs.size(),new DefaultThreadFactory(String.format("%s-%s",sourceContext.getSourceName(), sourceContext.getInstanceId())));
Review comment:
Because each task instance can consume multiple topics at the same time, each topic has independent threads, which can ensure that it does not affect each other and the performance is optimized
If the thread pool size is 1, the normal consumption of other topics will be blocked because one topic has no data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xche commented on pull request #8577: [Functions] Delete the message listener and add a thread to get the message from the consumer
Posted by GitBox <gi...@apache.org>.
xche commented on pull request #8577:
URL: https://github.com/apache/pulsar/pull/8577#issuecomment-730972770
> The correct solution would be to change the number listener threads for the pulsar client used in the TheadRuntime or create per instance pulsar clients.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xche removed a comment on pull request #8577: [Functions] Delete the message listener and add a thread to get the message from the consumer
Posted by GitBox <gi...@apache.org>.
xche removed a comment on pull request #8577:
URL: https://github.com/apache/pulsar/pull/8577#issuecomment-730972770
> The correct solution would be to change the number listener threads for the pulsar client used in the TheadRuntime or create per instance pulsar clients.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] reswqa commented on pull request #8577: [Functions] Delete the message listener and add a thread to get the m…
Posted by GitBox <gi...@apache.org>.
reswqa commented on pull request #8577:
URL: https://github.com/apache/pulsar/pull/8577#issuecomment-727959527
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xche closed pull request #8577: [Functions] Delete the message listener and add a thread to get the message from the consumer
Posted by GitBox <gi...@apache.org>.
xche closed pull request #8577:
URL: https://github.com/apache/pulsar/pull/8577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org