You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/02 09:12:23 UTC

[GitHub] [ignite-3] valepakh opened a new pull request, #971: IGNITE-17348 Add quit/exit command to Ignite3 CLI sql REPL

valepakh opened a new pull request, #971:
URL: https://github.com/apache/ignite-3/pull/971

   https://issues.apache.org/jira/browse/IGNITE-17348
   Do not pass registered commands to the SQL engine and combine completers.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] kgusakov commented on a diff in pull request #971: IGNITE-17348 Add quit/exit command to Ignite3 CLI sql REPL

Posted by GitBox <gi...@apache.org>.
kgusakov commented on code in PR #971:
URL: https://github.com/apache/ignite-3/pull/971#discussion_r940257330


##########
modules/cli/src/main/java/org/apache/ignite/cli/core/repl/executor/RegistryCommandExecutor.java:
##########
@@ -23,20 +23,26 @@
 import org.apache.ignite.cli.core.call.DefaultCallOutput;
 import org.apache.ignite.cli.core.call.StringCallInput;
 import org.jline.console.SystemRegistry;
+import org.jline.reader.ParsedLine;
+import org.jline.reader.Parser;
+import org.jline.reader.Parser.ParseContext;
 
 /**
  * Command executor based on {@link SystemRegistry}.
  */
 public class RegistryCommandExecutor implements Call<StringCallInput, Object> {
     private final SystemRegistry systemRegistry;
+    private final Parser parser;

Review Comment:
   ```suggestion
   
       private final Parser parser;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] Pochatkin commented on pull request #971: IGNITE-17348 Add quit/exit command to Ignite3 CLI sql REPL

Posted by GitBox <gi...@apache.org>.
Pochatkin commented on PR #971:
URL: https://github.com/apache/ignite-3/pull/971#issuecomment-1207897591

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] asfgit closed pull request #971: IGNITE-17348 Add quit/exit command to Ignite3 CLI sql REPL

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #971: IGNITE-17348 Add quit/exit command to Ignite3 CLI sql REPL
URL: https://github.com/apache/ignite-3/pull/971


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org