You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2017/10/10 22:07:30 UTC
[GitHub] storm pull request #2368: STORM-2771: By default don't run any tests as inte...
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2368
STORM-2771: By default don't run any tests as integration tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2771
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2368.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2368
----
commit cd1ca562ca9238acb89ebb26ac18983a049e7498
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2017-10-10T22:06:30Z
STORM-2771: By default don't run any tests as integration tests
----
---
[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2368
Thanks for trying it out. I think we can get the same effect as the annotation by setting `<java.integration.test.include>no.tests</java.integration.test.include>` in the default properties. It's similar to how integration-tests-only disables the unit tests.
+1 for the fix, with or without the annotation.
---
[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2368
@srdo I'm not sure I can try it out and see.
---
[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2368
@srdo I did some tests and it works. The only problem with it is that if I do something odd like `mvn clean install -Pall-tests -DskipTests` it ends up running all of the java integration tests. I'm not sure if that is a big deal or not. I will try to fix it, but I am going to have to see if maven supports some kind of conditionals in their macro substitution.
---
[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2368
Looks great, +1
---
[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2368
Maven does not support conditional properties. I would have to do some ugly things with a profile that is activated when a property is set, and I am not sure that even then I could make it work. Right now I like having the NoTests interface more than having skipTests not work in all situations. But that is just me, if others disagree I can change it, it is not a big deal to me.
---
[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2368
@srdo Made the change you suggested and it works great, thanks. I squashed the commits and pushed as new version. Have a look.
---
[GitHub] storm pull request #2368: STORM-2771: By default don't run any tests as inte...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2368
---
[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2368
Can we avoid using the dummy annotation by setting http://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html#skipTests to true for the default plugin configuration, and setting it to false for the integration-tests-only and all-tests profiles?
---