You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/02 06:43:41 UTC
[GitHub] [beam] Akshay-Iyangar opened a new pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Akshay-Iyangar opened a new pull request #11396:
URL: https://github.com/apache/beam/pull/11396
Add Configurable FluentBackoff to JdbcIO Write
[Jira ticket](https://issues.apache.org/jira/browse/BEAM-9742)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-641853251
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev removed a comment on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev removed a comment on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-638984073
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Akshay-Iyangar closed pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
Akshay-Iyangar closed pull request #11396:
URL: https://github.com/apache/beam/pull/11396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Varsha-Maurya commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
Varsha-Maurya commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-637312666
reopen the pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-638983908
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-640562379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-625987559
Hi, Cham requested that I take a look but I'm overloaded. Will attempt to look next week
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-625498060
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Akshay-Iyangar commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
Akshay-Iyangar commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-640467446
@aromanenko-dev - Addressed the feedback !!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-626641582
@udim no problem, I can take over of this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Akshay-Iyangar commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
Akshay-Iyangar commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-624902109
@lukecwik @aromanenko-dev @jfarr @timrobertson100 Let me know what you guys think needs to be done.
Seems like people are ok with making FluentBackOff public?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a change in pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on a change in pull request #11396:
URL: https://github.com/apache/beam/pull/11396#discussion_r435399974
##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -1217,6 +1297,16 @@ void set(
return toBuilder().setRetryStrategy(retryStrategy).build();
}
+ /**
+ * When a SQL exception occurs, {@link Write} uses this {@link RetryConfiguration} to
+ * exponentially back off and retry the statements based on the {@link RetryConfiguration}
+ * mentioned.
Review comment:
It would helpful to provide a simple example of using - here or in `JdbcIO` class Javadoc.
##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -903,6 +907,72 @@ public void teardown() throws Exception {
}
}
+ /**
+ * Builder used to help with retry configuration for {@link JdbcIO}. The retry configuration
+ * accepts maxAttempts and maxDuration for {@link FluentBackoff}.
+ */
+ @AutoValue
+ public abstract static class RetryConfiguration implements Serializable {
+
+ abstract int getMaxAttempts();
+
+ @Nullable
+ abstract Duration getMaxDuration();
+
+ @Nullable
+ abstract Duration getInitialDuration();
+
+ abstract RetryConfiguration.Builder builder();
+
+ @AutoValue.Builder
+ abstract static class Builder {
+ abstract Builder setMaxAttempts(int maxAttempts);
+
+ abstract Builder setMaxDuration(Duration maxDuration);
+
+ abstract Builder setInitialDuration(Duration initialDuration);
+
+ abstract RetryConfiguration build();
+ }
+
+ public static RetryConfiguration create(int maxAttempts) {
+ checkArgument(maxAttempts > 0, "maxAttempts must be greater than 0");
+ return create(maxAttempts, DEFAULT_MAX_CUMULATIVE_BACKOFF, DEFAULT_INITIAL_BACKOFF);
+ }
+
+ public static RetryConfiguration create(int maxAttempts, Duration maxDuration) {
+ checkArgument(maxAttempts > 0, "maxAttempts must be greater than 0");
+ checkArgument(
+ maxDuration != null && maxDuration.isLongerThan(Duration.ZERO),
+ "maxDuration must be greater than 0");
+ return create(maxAttempts, maxDuration, DEFAULT_INITIAL_BACKOFF);
+ }
+
+ public static RetryConfiguration create(Duration initialDuration, int maxAttempts) {
Review comment:
It's a bit confusing for user to have the overloaded methods where the same argument (eg, `maxAttempts`) changes its positions. I'd prefer to leave only one method `create()` with all three arguments to provide - `create(int maxAttempts, Duration maxDuration, Duration initialDuration)`.
Also, make `DEFAULT_INITIAL_BACKOFF ` and `DEFAULT_MAX_CUMULATIVE_BACKOFF` as the constants of `RetryConfiguration` and make them public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Akshay-Iyangar commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
Akshay-Iyangar commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-637828525
@aromanenko-dev @lukecwik could you'll please have a look? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a change in pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on a change in pull request #11396:
URL: https://github.com/apache/beam/pull/11396#discussion_r435399974
##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -1217,6 +1297,16 @@ void set(
return toBuilder().setRetryStrategy(retryStrategy).build();
}
+ /**
+ * When a SQL exception occurs, {@link Write} uses this {@link RetryConfiguration} to
+ * exponentially back off and retry the statements based on the {@link RetryConfiguration}
+ * mentioned.
Review comment:
It would be helpful to provide a simple example of usage - here or in `JdbcIO` class Javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev removed a comment on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev removed a comment on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-638983908
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-625351289
Well, I didn't see any principal "against" to make FluentBackoff public but I'm not sure that it will be moved to another package or `util` will become public soon. So for now, I'd rather keep the same strategy as we did for other IOs by creating a custom RetryConfiguration for certain IO.
@lukecwik wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Varsha-Maurya removed a comment on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
Varsha-Maurya removed a comment on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-637312666
reopen the pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-633894816
Hi @Akshay-Iyangar, kind ping regarding this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on a change in pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #11396:
URL: https://github.com/apache/beam/pull/11396#discussion_r421795105
##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -257,6 +258,28 @@ public boolean apply(SQLException e) {
}
}
+ /**
+ * This is the default {@link FluentBackoffConfiguration} that we use to retry when a {@link
+ * SQLException} occurs.
+ */
+ public static class DefaultFluentBackoffConfiguration implements FluentBackoffConfiguration {
Review comment:
It looks like we should stick with the pattern other IO authors have taken in the mean time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev removed a comment on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev removed a comment on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-640562379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Akshay-Iyangar commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
Akshay-Iyangar commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-634262185
@aromanenko-dev - Sorry for a little busy, will make the changes today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-638984073
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-638984333
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged pull request #11396:
URL: https://github.com/apache/beam/pull/11396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-626642453
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a change in pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on a change in pull request #11396:
URL: https://github.com/apache/beam/pull/11396#discussion_r422977908
##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -257,6 +258,28 @@ public boolean apply(SQLException e) {
}
}
+ /**
+ * This is the default {@link FluentBackoffConfiguration} that we use to retry when a {@link
+ * SQLException} occurs.
+ */
+ public static class DefaultFluentBackoffConfiguration implements FluentBackoffConfiguration {
Review comment:
I agree with @lukecwik - we should stay consistent with that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-642096389
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Akshay-Iyangar commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
Posted by GitBox <gi...@apache.org>.
Akshay-Iyangar commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-640828807
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org