[jira] [Updated] (HBASE-4254) Get tests passing on Hadoop 23

["Gregory Chanan (Updated) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Chanan updated HBASE-4254:
----------------------------------

    Attachment: HBASE-4254-92.patch

* Attached HBASE-4254-92.patch*

NOTE: I'm not sure if we should commit this, this is just a brainstorm.

This is a patch for hbase-0.92 that fixes TestLogRolling.testLogRollOnPipelineRestart against hadoop-0.23 while not breaking it against hadoop-1.0.0.  If we want to commit this, I can create patches for trunk/94.

>From my comment:
1) It sounds like under the current design, we need to call recoverLease to read from the HLog:

>From the recovery design doc (see HDFS-2288):
"• Any
 WaitingToBeRecovered
 replica 
does 
not 
serve 
any 
read and
 does 
not participate
 in 
a 
pipeline 
recovery.
• A
 WaitingToBeRecovered 
replica 
will
 either 
become 
out dated
 and 
be deleted
 by 
NN 
if 
the 
client 
is 
still 
alive 
or 
be 
changed
 to
 be 
finalized 
as 
a result
 of 
lease
 recovery
 if
 the 
client
 dies"

This is basically what I've done: if we cannot get a reader for the HLog b/c replicas-awaiting-recovery do not return a visible length, recover the lease, wait for it to finish, then retry getting the HLog reader.  (Aside: It would be nice if the exception HDFS returned in this state was clearer than IOException).

Is this is correct place for this code?  Do we need it everywhere we call HLog.getReader?  Any thoughts?
                
> Get tests passing on Hadoop 23
> ------------------------------
>
>                 Key: HBASE-4254
>                 URL: https://issues.apache.org/jira/browse/HBASE-4254
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.92.2
>
>         Attachments: HBASE-4254-92.patch
>
>
> Currently some 30 or so tests are failing on the "HBase-trunk-on-hadoop-23" build. It looks like most are reflection-based issues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira