You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/07 22:54:20 UTC
[jira] [Commented] (BEAM-732) Placing Timers into the global window
causes tests to Flake
[ https://issues.apache.org/jira/browse/BEAM-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556509#comment-15556509 ]
ASF GitHub Bot commented on BEAM-732:
-------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/1069
[BEAM-732] Only remove Elements that were pending from Pending Elements
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Update the comparator so elements will only be removed from the
collection of pending elements if they were formerly added. This ensures
that elements cannot be removed if a timer delivery has an identical
timestamp to them.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam remove_pending_equality
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1069.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1069
----
commit da57ae814bdc9c8d0661c27906f4a6e3c9e7474f
Author: Thomas Groh <tg...@google.com>
Date: 2016-10-07T22:50:05Z
Only remove Elements that were pending from Pending Elements
Update the comparator so elements will only be removed from the
collection of pending elements if they were formerly added. This ensures
that elements cannot be removed if a timer delivery has an identical
timestamp to them.
----
> Placing Timers into the global window causes tests to Flake
> -----------------------------------------------------------
>
> Key: BEAM-732
> URL: https://issues.apache.org/jira/browse/BEAM-732
> Project: Beam
> Issue Type: Bug
> Reporter: Thomas Groh
> Assignee: Thomas Groh
>
> When timers are delivered in the global window rather than in empty windows, the fact that they may share a timestamp with pending elements causes the pending elements to be removed from the collection of pending elements, allowing the watermark to advance inappropriately.
> Only remove elements that have become pending. Use a comparator that compares different elements as nonequal to do so.
> See WatermarkManager.AppliedPTransformInputWatermark
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)