You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/04/24 16:14:54 UTC

[GitHub] spark pull request #21142: [SPARK-24069][R] Add array_min / array_max functi...

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/21142

    [SPARK-24069][R] Add array_min / array_max functions

    ## What changes were proposed in this pull request?
    
    This PR proposes to add array_max and array_min in R side too.
    
    array_max:
    
    ```r
    df <- createDataFrame(cbind(model = rownames(mtcars), mtcars))
    mutated <- mutate(df, v1 = create_array(df$gear, df$am, df$carb))
    head(select(mutated, array_max(mutated$v1)))
    ```
    
    ```
      array_max(v1)
    1             4
    2             4
    3             4
    4             3
    5             3
    6             3
    ```
    
    array_min:
    
    ```r
    df <- createDataFrame(cbind(model = rownames(mtcars), mtcars))
    mutated <- mutate(df, v1 = create_array(df$mpg, df$cyl, df$hp))
    head(select(mutated, array_min(mutated$v1)))
    ```
    
    ```
      array_min(v1)
    1             6
    2             6
    3             4
    4             6
    5             8
    6             6
    ```
    
    ## How was this patch tested?
    
    Unit tests were added in `R/pkg/tests/fulltests/test_sparkSQL.R` and manually tested. Documentation was manually built and verified.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark sparkr_array_min_array_max

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21142
    
----

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    **[Test build #89791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89791/testReport)** for PR 21142 at commit [`a3677f2`](https://github.com/apache/spark/commit/a3677f2e6d1ae1483f2203ce9d1b58e29fdada87).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2633/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89824/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    **[Test build #89824 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89824/testReport)** for PR 21142 at commit [`0804a92`](https://github.com/apache/spark/commit/0804a920298ac2a84b49c60aa515c286c40440c3).
     * This patch **fails due to an unknown error code, -9**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    cc @felixcheung, maybe, I will try to group more next time .. (2 ~ 4 functions ?)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2657/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    **[Test build #89827 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89827/testReport)** for PR 21142 at commit [`0804a92`](https://github.com/apache/spark/commit/0804a920298ac2a84b49c60aa515c286c40440c3).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89791/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2662/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    Merged to master.
    
    Thanks for reviewing this @felixcheung.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    **[Test build #89827 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89827/testReport)** for PR 21142 at commit [`0804a92`](https://github.com/apache/spark/commit/0804a920298ac2a84b49c60aa515c286c40440c3).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21142: [SPARK-24069][R] Add array_min / array_max functions

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21142
  
    **[Test build #89824 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89824/testReport)** for PR 21142 at commit [`0804a92`](https://github.com/apache/spark/commit/0804a920298ac2a84b49c60aa515c286c40440c3).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org