You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Matt <mi...@gmail.com> on 2016/02/09 19:39:30 UTC
Review Request 43368: assign_master_components.js breaks next step in
certain case
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43368/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-14701
https://issues.apache.org/jira/browse/AMBARI-14701
Repository: ambari
Description
-------
There was noAction onSecondary (Cancel button). Implemented onSecondary, and modified the callback for the same.
Diffs
-----
ambari-web/app/mixins/wizard/assign_master_components.js 0693507
Diff: https://reviews.apache.org/r/43368/diff/
Testing
-------
Unit tests passed.
24226 tests complete (20 seconds)
156 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52.915 s
[INFO] Finished at: 2016-02-09T10:37:09-08:00
[INFO] Final Memory: 12M/311M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43368: assign_master_components.js breaks next
step in certain case
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43368/
-----------------------------------------------------------
(Updated Feb. 12, 2016, 5:46 a.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
Bugs: AMBARI-14701
https://issues.apache.org/jira/browse/AMBARI-14701
Repository: ambari
Description
-------
There was noAction onSecondary (Cancel button). Implemented onSecondary, and modified the callback for the same.
Diffs (updated)
-----
ambari-web/app/mixins/wizard/assign_master_components.js 0693507
Diff: https://reviews.apache.org/r/43368/diff/
Testing (updated)
-------
Unit tests passed.
24292 tests complete (19 seconds)
156 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:15 min
[INFO] Finished at: 2016-02-12T05:45:05-08:00
[INFO] Final Memory: 12M/311M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43368: assign_master_components.js breaks next
step in certain case
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43368/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 5:16 p.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
Bugs: AMBARI-14701
https://issues.apache.org/jira/browse/AMBARI-14701
Repository: ambari
Description
-------
There was noAction onSecondary (Cancel button). Implemented onSecondary, and modified the callback for the same.
Diffs (updated)
-----
ambari-web/app/mixins/wizard/assign_master_components.js 0693507
Diff: https://reviews.apache.org/r/43368/diff/
Testing (updated)
-------
Unit tests passed.
24230 tests complete (21 seconds)
156 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 48.223 s
[INFO] Finished at: 2016-02-10T17:11:55-08:00
[INFO] Final Memory: 12M/310M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43368: assign_master_components.js breaks next
step in certain case
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43368/#review118509
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 10, 2016, 12:03 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43368/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 12:03 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14701
> https://issues.apache.org/jira/browse/AMBARI-14701
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There was noAction onSecondary (Cancel button). Implemented onSecondary, and modified the callback for the same.
>
>
> Diffs
> -----
>
> ambari-web/app/mixins/wizard/assign_master_components.js 0693507
>
> Diff: https://reviews.apache.org/r/43368/diff/
>
>
> Testing
> -------
>
> Unit tests passed.
> 24226 tests complete (19 seconds)
> 156 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50.380 s
> [INFO] Finished at: 2016-02-09T15:56:14-08:00
> [INFO] Final Memory: 12M/311M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43368: assign_master_components.js breaks next
step in certain case
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43368/#review118684
-----------------------------------------------------------
Ship it!
Ship It!
- Lav Jain
On Feb. 10, 2016, 12:03 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43368/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 12:03 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14701
> https://issues.apache.org/jira/browse/AMBARI-14701
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There was noAction onSecondary (Cancel button). Implemented onSecondary, and modified the callback for the same.
>
>
> Diffs
> -----
>
> ambari-web/app/mixins/wizard/assign_master_components.js 0693507
>
> Diff: https://reviews.apache.org/r/43368/diff/
>
>
> Testing
> -------
>
> Unit tests passed.
> 24226 tests complete (19 seconds)
> 156 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50.380 s
> [INFO] Finished at: 2016-02-09T15:56:14-08:00
> [INFO] Final Memory: 12M/311M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43368: assign_master_components.js breaks next
step in certain case
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43368/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 4:03 p.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
Bugs: AMBARI-14701
https://issues.apache.org/jira/browse/AMBARI-14701
Repository: ambari
Description
-------
There was noAction onSecondary (Cancel button). Implemented onSecondary, and modified the callback for the same.
Diffs
-----
ambari-web/app/mixins/wizard/assign_master_components.js 0693507
Diff: https://reviews.apache.org/r/43368/diff/
Testing
-------
Unit tests passed.
24226 tests complete (19 seconds)
156 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 50.380 s
[INFO] Finished at: 2016-02-09T15:56:14-08:00
[INFO] Final Memory: 12M/311M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43368: assign_master_components.js breaks next
step in certain case
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43368/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 3:57 p.m.)
Review request for Ambari.
Bugs: AMBARI-14701
https://issues.apache.org/jira/browse/AMBARI-14701
Repository: ambari
Description
-------
There was noAction onSecondary (Cancel button). Implemented onSecondary, and modified the callback for the same.
Diffs (updated)
-----
ambari-web/app/mixins/wizard/assign_master_components.js 0693507
Diff: https://reviews.apache.org/r/43368/diff/
Testing (updated)
-------
Unit tests passed.
24226 tests complete (19 seconds)
156 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 50.380 s
[INFO] Finished at: 2016-02-09T15:56:14-08:00
[INFO] Final Memory: 12M/311M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt