You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "sureshanaparti (via GitHub)" <gi...@apache.org> on 2026/09/30 08:18:59 UTC
[PR] Async jobs improvements [cloudstack]
sureshanaparti opened a new pull request, #14270:
URL: https://github.com/apache/cloudstack/pull/14270
### Description
This PR has the following async jobs related improvements.
- Lists async jobs by their status, and duration.
- Support cancel async jobs (wherever possible, cancels underlying hypervisor jobs, mainly VMware, XenServer)
- Links jobs to events
- Lists usage server jobs
- Adds new 'Activity' section in the UI with Jobs, Events, Alerts. Jobs tabs on Instances, Volumes and Management Servers.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6335682090
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6459302316
<b>[SF] Trillian test result (tid-17280)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 68751 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14270-t17280-kvm-ol8.zip
Smoke tests completed. 158 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6414728604
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6638602530
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5910117543
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6319867825
<b>[SF] Trillian Build Failed (tid-17186)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6315953575
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6338421163
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@cloudstack.apache.org>.
github-actions[bot] commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6863501684
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5909439005
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5924986273
<b>[SF] Trillian test result (tid-17046)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57737 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14270-t17046-kvm-ol8.zip
Smoke tests completed. 157 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5950973399
<b>[SF] Trillian test result (tid-17050)</b>
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 158794 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14270-t17050-vmware-70u3.zip
Smoke tests completed. 147 look OK, 10 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 115.11 | test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup | `Error` | 21.48 | test_affinity_groups.py
test_deploy_more_vms_than_limit_allows | `Error` | 142.15 | test_deploy_vms_in_parallel.py
test_12_deploy_vm_with_root_disk_encryption | `Error` | 14.16 | test_kms_lifecycle.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 50.23 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.14 | test_kubernetes_clusters.py
test_12_test_deploy_cluster_different_offerings_per_node_type | `Failure` | 156.78 | test_kubernetes_clusters.py
test_13_test_add_external_nodes_to_cluster | `Failure` | 118.34 | test_kubernetes_clusters.py
ContextSuite context=TestListVolumes>:setup | `Error` | 0.00 | test_list_volumes.py
test_01_non_strict_host_anti_affinity | `Failure` | 152.62 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 45.04 | test_nonstrict_affinity_group.py
test_01_vpn_usage | `Error` | 0.04 | test_usage.py
test_01_deploy_vm_on_specific_host | `Error` | 3609.29 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 3610.13 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 3609.33 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 3610.06 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 3609.37 | test_vm_deployment_planner.py
ContextSuite context=TestMigrateVMStrictTags>:setup | `Error` | 0.00 | test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success | `Error` | 3611.58 | test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure | `Error` | 3613.01 | test_vm_strict_host_tags.py
ContextSuite context=TestRestoreVMStrictTags>:teardown | `Error` | 3617.40 | test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success | `Error` | 3613.23 | test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure | `Error` | 3609.68 | test_vm_strict_host_tags.py
ContextSuite context=TestScaleVMStrictTags>:teardown | `Error` | 3612.56 | test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 3607.23 | test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 3669.33 | test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 3607.73 | test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 3611.86 | test_vm_strict_host_tags.py
ContextSuite context=TestVMDeploymentPlannerStrictTags>:teardown | `Error` | 6.88 | test_vm_strict_host_tags.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6321468695
<b>[SF] Trillian Build Failed (tid-17192)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@cloudstack.apache.org>.
github-actions[bot] commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6750768876
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6795631297
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5912736375
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6338431752
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6315969050
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6311234798
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6420044917
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6640282660
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6370231672
<b>[SF] Trillian test result (tid-17215)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 73938 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14270-t17215-kvm-ol8.zip
Smoke tests completed. 152 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_06_cancel_completed_job_is_refused | `Failure` | 0.10 | test_async_jobs.py
test_10_cancel_of_power_operation_is_refused | `Failure` | 0.24 | test_async_jobs.py
test_11_cancelled_offline_volume_migration_keeps_the_volume | `Error` | 42.63 | test_async_jobs.py
test_13_cancelled_volume_snapshot_leaves_nothing | `Failure` | 14.42 | test_async_jobs.py
ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py
test_05_list_volumes_isrecursive | `Failure` | 0.05 | test_list_volumes.py
test_07_list_volumes_listall | `Failure` | 0.04 | test_list_volumes.py
test_list_system_vms_metrics_history | `Failure` | 1.00 | test_metrics_api.py
test_1_userdata_on_ssvm | `Failure` | 124.86 | test_systemvm_userdata.py
test_2_userdata_on_cpvm | `Failure` | 113.80 | test_systemvm_userdata.py
test_3_userdata_on_vr | `Failure` | 74.83 | test_systemvm_userdata.py
test_06_download_detached_volume | `Failure` | 307.87 | test_volumes.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6741907184
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6773836096
<b>[SF] Trillian test result (tid-17516)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 85423 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14270-t17516-kvm-ol8.zip
Smoke tests completed. 156 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_primary_storage_nfs | `Error` | 0.30 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.48 | test_primary_storage.py
test_01_primary_storage_scope_change | `Error` | 0.20 | test_primary_storage_scope.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6432889569
<b>[SF] Trillian Build Failed (tid-17278)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@cloudstack.apache.org>.
github-actions[bot] commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6564282265
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6416585014
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6797477196
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@cloudstack.apache.org>.
github-actions[bot] commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6802571061
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6320779182
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub) via commits" <co...@cloudstack.apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6638566415
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6335698293
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6411076250
> test_async_jobs.py
@sureshanaparti
it looks like the failures are related ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6211936278
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✖️ suse15. SL-JID 19579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "nvazquez (via GitHub) via commits" <co...@cloudstack.apache.org>.
nvazquez commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6565707649
Hi @sureshanaparti can you please address the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub) via commits" <co...@cloudstack.apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6823777876
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6853783199
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 20048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5910565437
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6276293925
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6341288492
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6317876121
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6422045185
<b>[SF] Trillian Build Failed (tid-17273)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6414721834
> > test_async_jobs.py
>
> @sureshanaparti it looks like the failures are related ?
seems to be unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub) via commits" <co...@cloudstack.apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6739556521
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub) via commits" <co...@cloudstack.apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6632423206
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6851772695
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5907284681
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/14270?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.70%. Comparing base ([`510d0ec`](https://app.codecov.io/gh/apache/cloudstack/commit/510d0ec3785efe3cce65ccd1247682b91f4492d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`963a15a`](https://app.codecov.io/gh/apache/cloudstack/commit/963a15a9907915dfe4dee839519acb0393510991?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (510d0ec) and HEAD (963a15a). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (510d0ec) | HEAD (963a15a) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #14270 +/- ##
=============================================
- Coverage 19.91% 3.70% -16.22%
=============================================
Files 6373 489 -5884
Lines 577230 42096 -535134
Branches 70696 7964 -62732
=============================================
- Hits 114942 1558 -113384
+ Misses 449722 40312 -409410
+ Partials 12566 226 -12340
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/14270/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/14270/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.70% <ø> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/14270/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cloudstack/pull/14270?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5909417249
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6420082289
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6310233974
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6633238567
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 19899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6343005790
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6319988090
<b>[SF] Trillian Build Failed (tid-17185)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub) via commits" <co...@cloudstack.apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6745054357
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub) via commits" <co...@cloudstack.apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6795591329
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5935902376
<b>[SF] Trillian test result (tid-17051)</b>
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 92954 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14270-t17051-xcpng82.zip
Smoke tests completed. 147 look OK, 10 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_events_resource | `Error` | 245.25 | test_events_resource.py
test_12_deploy_vm_with_root_disk_encryption | `Error` | 12.06 | test_kms_lifecycle.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 966.38 | test_kubernetes_clusters.py
test_09_vpc_source_nat_ip_update | `Error` | 25.55 | test_network_extension_namespace.py
test_01_non_strict_host_anti_affinity | `Error` | 234.93 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 62.44 | test_nonstrict_affinity_group.py
test_05_disk_offering_strictness_true | `Failure` | 630.02 | test_service_offerings.py
test_06_disk_offering_strictness_false | `Failure` | 635.13 | test_service_offerings.py
test_01_volume_usage | `Failure` | 96.02 | test_usage.py
test_01_vpn_usage | `Error` | 1.08 | test_usage.py
test_11_destroy_vm_and_volumes | `Error` | 21.02 | test_vm_life_cycle.py
test_change_service_offering_for_vm_with_snapshots | `Failure` | 1023.13 | test_vm_snapshots.py
test_01_migrate_vm_strict_tags_success | `Error` | 52.86 | test_vm_strict_host_tags.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#discussion_r4142461918
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/BaseDeployVMCmd.java:
##########
@@ -875,4 +875,8 @@ public String getEventDescription() {
public ApiCommandResourceType getApiResourceType() {
return ApiCommandResourceType.VirtualMachine;
}
+
+ public boolean isCancellable() {
+ return true;
+ }
Review Comment:
This method is never consulted by cancellation: `AsyncJobManagerImpl` reads `APICommand.cancellable()` from the concrete command annotation. Both `DeployVMCmd` and `CreateVMFromBackupCmd` retain the annotation default `false`, so active deploy jobs are always rejected despite this change claiming they are cancellable. Set `cancellable = true` on the applicable concrete `@APICommand` annotations (or change the cancellation contract consistently).
##########
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentAttache.java:
##########
@@ -231,6 +234,24 @@ protected synchronized void cancel(final long seq) {
}
}
+ /** Default false: an attache that cannot ask its resource must not claim it. */
+ protected boolean isExecutionCancellable(final long seq) {
+ return false;
+ }
+
+ /** Returns true only when the resource's work was stopped (or nothing was left to stop). */
+ protected boolean cancelRunning(final long seq) {
+ return false;
+ }
+
+ /** Job-cancel path; distinct from cancel(seq), which is also the timeout path and never reaches the hypervisor. */
+ public boolean cancelExecution(final long seq) {
+ _cancelledSequences.add(seq);
+ final boolean stopped = cancelRunning(seq);
+ cancel(seq);
+ return stopped;
+ }
Review Comment:
If the resource refuses cancellation after the earlier probe (for example, the task finishes or becomes non-cancellable in between), this still marks the sequence cancelled and disconnects its listener. `AgentManagerImpl.cancelJobExecution` then reports refusal, but the waiting worker receives `OperationCancelledException` instead of being allowed to finish, so the supposedly refused cancellation can fail the job. Only mark/cancel the attachment after `cancelRunning` succeeds.
##########
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##########
@@ -2064,6 +2109,99 @@ protected List<Long> findAgentsBehindOnPing() {
}
}
+ /** Stops in-flight work of jobs cancelled on this management server and acknowledges them. */
+ protected class CancelledJobsCheckTask extends ManagedContextRunnable {
+ @Override
+ protected void runInContext() {
+ try {
+ final long now = System.currentTimeMillis();
+ _cancelledJobs.values().removeIf(firstSeen -> now - firstSeen > CANCELLED_JOB_MEMORY_MS);
+
+ for (final AsyncJobVO job : asyncJobManager.listCancelledJobsExecutingOn(_nodeId)) {
+ _cancelledJobs.putIfAbsent(job.getId(), now);
+ if (_jobToHostIdAndReqSequenceMap.containsKey(job.getId())) {
+ logger.info("Job-{} on {} {} was cancelled, stopping its in-flight commands",
+ job.getId(), job.getInstanceType(), job.getInstanceId());
+ if (!cancelJobExecution(job.getId(), "Job was cancelled")) {
+ logger.warn("Not every in-flight command of cancelled job-{} could be stopped; the rest will run to completion", job.getId());
+ }
+ }
+ asyncJobManager.finalizeCancelledJob(job.getId());
Review Comment:
When cancellation reaches the management server executing a remote job and an in-flight command cannot be stopped, this branch logs that the command will continue but immediately finalizes/removes the job as CANCELLED. The backend can therefore keep mutating resources after the job is terminal, and the row will no longer be polled for another stop attempt. Keep the job assigned and retry until its in-flight work is stopped or naturally exits; only then finalize it.
##########
server/src/main/java/com/cloud/usage/UsageServiceImpl.java:
##########
@@ -500,4 +504,71 @@ public boolean removeRawUsageRecords(RemoveRawUsageRecordsCmd cmd) throws Invali
_usageDao.expungeAllOlderThan(interval, ConfigurationManagerImpl.DELETE_QUERY_BATCH_SIZE.value());
return true;
}
+
+ @Override
+ public ListResponse<UsageJobResponse> getUsageJobs(ListUsageJobsCmd cmd) {
+ Filter usageJobFilter = new Filter(UsageJobVO.class, "id", true, cmd.getStartIndex(), cmd.getPageSizeVal());
+ SearchCriteria<UsageJobVO> sc = _usageJobDao.createSearchCriteria();
+
+ if (StringUtils.isNotBlank(cmd.getUsageServer())) {
+ sc.addAnd("host", SearchCriteria.Op.EQ, cmd.getUsageServer().trim());
+ }
+
+ Object startDate = cmd.getStartDate();
+ if (startDate != null) {
+ sc.addAnd("startDate", SearchCriteria.Op.GTEQ, startDate);
+ }
+
+ Object endDate = cmd.getEndDate();
+ if (endDate != null) {
+ sc.addAnd("startDate", SearchCriteria.Op.LTEQ, endDate);
+ }
+
+ if (cmd.getDuration() != null) {
+ // usage job timestamps are GMT
+ Date lastDate = new Date(DateUtil.currentGMTTime().getTime() - TimeUnit.HOURS.toMillis(cmd.getDuration()));
+
+ SearchCriteria<UsageJobVO> scc = _usageJobDao.createSearchCriteria();
+ scc.addOr("startDate", SearchCriteria.Op.GTEQ, lastDate);
+ scc.addOr("endDate", SearchCriteria.Op.GTEQ, lastDate);
+ sc.addAnd("startDate", SearchCriteria.Op.SC, scc);
+ }
+
+ Pair<List<UsageJobVO>, Integer> usageJobs = null;
+ TransactionLegacy txn = TransactionLegacy.open(TransactionLegacy.USAGE_DB);
+ try {
+ usageJobs = _usageJobDao.searchAndCount(sc, usageJobFilter);
+ } finally {
+ txn.close();
+
+ // switch back to VMOPS_DB
+ TransactionLegacy swap = TransactionLegacy.open(TransactionLegacy.CLOUD_DB);
+ swap.close();
+ }
+
+ ListResponse<UsageJobResponse> response = new ListResponse<>();
+ if (usageJobs != null) {
+ List<UsageJobResponse> responses = new ArrayList<>();
+ for (UsageJobVO job : usageJobs.first()) {
+ UsageJobResponse jobResponse = createUsageJobResponse(job);
+ responses.add(jobResponse);
+ }
+ response.setResponses(responses, usageJobs.second());
+ }
+
+ return response;
+ }
+
+ private UsageJobResponse createUsageJobResponse(UsageJobVO job) {
+ UsageJobResponse jobResponse = new UsageJobResponse();
+ jobResponse.setUsageServer(job.getHost());
+ jobResponse.setJobType(job.getJobType());
+ jobResponse.setScheduled(job.getScheduled());
+ jobResponse.setStartDate(job.getStartDate());
+ jobResponse.setEndDate(job.getEndDate());
+ jobResponse.setSuccess(job.getSuccess());
+ jobResponse.setHeartbeat(job.getHeartbeat());
Review Comment:
The new response declares `executiontime` and the UI displays it, but this mapper never copies `UsageJobVO.getExecTime()`. Consequently every `listUsageJobs` response omits the execution time and the new table column remains empty.
##########
engine/orchestration/src/main/java/com/cloud/agent/manager/DirectAgentAttache.java:
##########
@@ -139,14 +237,17 @@ protected void finalize() throws Throwable {
private synchronized void queueTask(Task task) {
tasks.add(task);
+ _taskRequests.put(task._req.getSequence(), task._req);
}
private synchronized void scheduleFromQueue() {
logger.trace("Agent attache [id: {}, uuid: {}, name: {}], task queue size={}, outstanding tasks={}",
_id, _uuid, _name, tasks.size(), _outstandingTaskCount.get());
while (!tasks.isEmpty() && _outstandingTaskCount.get() < _agentMgr.getDirectAgentThreadCap()) {
_outstandingTaskCount.incrementAndGet();
- _agentMgr.getDirectAgentPool().execute(tasks.remove());
+ Task task = tasks.remove();
+ Future<?> future = _agentMgr.getDirectAgentPool().submit(task);
+ _taskFutures.put(task._req.getSequence(), future);
Review Comment:
`submit` may execute and finish `task` before the returned future is inserted. In that ordering, the task's `finally` removes a missing entry and this subsequent `put` permanently retains a completed future, leaking one map entry per sufficiently fast request and making the sequence appear to have a running task. Remove a future that is already done after insertion; if it finishes later, the existing `finally` handles it.
##########
ui/src/config/section/activity.js:
##########
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import store from '@/store'
+
+export default {
+ name: 'activity',
+ title: 'label.activity',
+ icon: 'AuditOutlined',
+ permission: ['listEvents'],
+ children: [
Review Comment:
This parent permission hides the entire Activity section unless `listEvents` is granted, even when a role has `listAsyncJobs` or `listAlerts`. Route permissions are enforced before child filtering (`ui/src/store/modules/permission.js:44-55`), so custom roles with only Jobs or Alerts access cannot reach their permitted child. Leave the heterogeneous parent unrestricted and let each child's permission control visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5910546573
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#discussion_r4142441468
##########
api/src/main/java/org/apache/cloudstack/api/command/user/job/ListAsyncJobsCmd.java:
##########
@@ -26,18 +33,22 @@
import org.apache.cloudstack.api.response.AsyncJobResponse;
import org.apache.cloudstack.api.response.ListResponse;
import org.apache.cloudstack.api.response.ManagementServerResponse;
+import org.apache.cloudstack.jobs.JobInfo;
-@APICommand(name = "listAsyncJobs", description = "Lists all pending asynchronous jobs for the Account.", responseObject = AsyncJobResponse.class,
+@APICommand(name = "listAsyncJobs", description = "Lists asynchronous jobs for the Account.", responseObject = AsyncJobResponse.class,
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
public class ListAsyncJobsCmd extends BaseListAccountResourcesCmd {
/////////////////////////////////////////////////////
//////////////// API parameters /////////////////////
/////////////////////////////////////////////////////
- @Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE, description = "The start date of the async job (use format \"yyyy-MM-dd'T'HH:mm:ss'+'SSSS\")")
+ @Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE, description = "The start date from which the async jobs should be listed. Only jobs created on or after this date will be included. (use format \"yyyy-MM-dd'T'HH:mm:ss'+'SSSS\")")
private Date startDate;
+ @Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE, description = "The end date up to which the async jobs should be listed. Only jobs created on or before this date will be included. (use format \"yyyy-MM-dd'T'HH:mm:ss'+'SSSS\")")
Review Comment:
```suggestion
@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE, description = "The end date up to which the async jobs should be listed. Only jobs created on or before this date will be included. (use format \"yyyy-MM-dd'T'HH:mm:ss'+'SSSS\")", since = "24.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5912779033
@sureshanaparti a [SL] Trillian-Jenkins matrix job (ol8 mgmt + kvm-ol8, ubuntu22 mgmt + kvm-ubuntu22, ol8 mgmt + vmware-70u3, ol9 mgmt + xcpng82) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5928339241
<b>[SF] Trillian test result (tid-17048)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 65082 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14270-t17048-kvm-ol8.zip
Smoke tests completed. 157 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6414751321
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6632445205
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6320010099
<b>[SF] Trillian Build Failed (tid-17188)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6320797310
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6211123161
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6338971944
<b>[SF] Trillian Build Failed (tid-17205)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6739592350
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6826035948
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 20022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-5913822252
<b>[SF] Trillian Build Failed (tid-17049)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6211130764
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6064938822
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6320170283
<b>[SF] Trillian Build Failed (tid-17187)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6337486503
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6341269258
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#discussion_r4356793194
##########
api/src/main/java/org/apache/cloudstack/api/command/user/job/ListAsyncJobsCmd.java:
##########
@@ -67,15 +103,56 @@ public String getResourceType() {
return resourceType;
}
+ public List<Long> getJobStatuses() {
+ if (jobStatuses == null) {
+ return null;
+ }
+
+ if (jobStatuses.isEmpty()) {
+ throw new InvalidParameterValueException("Empty job status");
+ }
+
+ List<Long> statuses = new ArrayList<>(jobStatuses.size());
+ for (String status : jobStatuses) {
+ statuses.add((long)parseJobStatus(status).value());
+ }
+ return statuses;
+ }
Review Comment:
`job_status` is represented as an `int` in the DB/VOs, but this accessor returns `List<Long>`, which can cause avoidable type mismatches downstream (e.g., IN-clauses built over integer columns). Prefer returning `List<Integer>` (or `List<Short>`/`List<Long>` consistently across the job layer), and keep the types aligned with `AsyncJobJoinVO.getStatus()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6310242254
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6745101287
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "blueorangutan (via GitHub) via commits" <co...@cloudstack.apache.org>.
blueorangutan commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6823819217
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@cloudstack.apache.org>.
github-actions[bot] commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6824872187
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Async jobs improvements [cloudstack]
Posted by "sureshanaparti (via GitHub) via commits" <co...@cloudstack.apache.org>.
sureshanaparti commented on PR #14270:
URL: https://github.com/apache/cloudstack/pull/14270#issuecomment-6851722430
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org