You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/08/06 13:27:51 UTC

[kudu-CR] Prepare for upgrading to Hive 3 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14018


Change subject: Prepare for upgrading to Hive 3
......................................................................

Prepare for upgrading to Hive 3

This patch contains build and test changes that
work on both Hive 2 and Hive 3 to minimize the
changes required when upgrading to Hive 3.

- Uses the Hive `schematool` to initialized the
derby database in the MiniHms. This fixes issues
with autoCreate and is more representative of a
production environment.
- Adjust logging configuration in the MiniHMS to be
more explicit.
- Workaround HADOOP-8719 by hardcoding the
HADOOP_OS_TYPE.
- Workaround HIVE-21614 by using `LIKE` instead
of `=` when filtering tables.

Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
---
M src/kudu/hms/CMakeLists.txt
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/mini_hms.cc
M src/kudu/hms/mini_hms.h
M src/kudu/util/subprocess.cc
M src/kudu/util/subprocess.h
M thirdparty/package-hadoop.sh
8 files changed, 55 insertions(+), 23 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14018/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 )

Change subject: Prepare for upgrading to Hive 3
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Aug 2019 21:46:19 +0000
Gerrit-HasComments: No

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14018

to look at the new patch set (#4).

Change subject: Prepare for upgrading to Hive 3
......................................................................

Prepare for upgrading to Hive 3

This patch contains build and test changes that work on both Hive 2 and
Hive 3 to minimize the changes required when upgrading to Hive 3.

- Uses the Hive `schematool` to initialize the derby database in the
MiniHms. This fixes issues with autoCreate and is more representative of a
production environment.
- Adjust logging configuration in the MiniHms to be more explicit.
- Workaround HADOOP-8719 by hardcoding the HADOOP_OS_TYPE.
- Workaround HIVE-21614 by using `LIKE` instead of `=` when filtering
tables.

Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
---
M src/kudu/hms/CMakeLists.txt
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/mini_hms.cc
M src/kudu/hms/mini_hms.h
M src/kudu/util/subprocess.cc
M src/kudu/util/subprocess.h
M thirdparty/package-hadoop.sh
8 files changed, 58 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14018/4
-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14018

to look at the new patch set (#2).

Change subject: Prepare for upgrading to Hive 3
......................................................................

Prepare for upgrading to Hive 3

This patch contains build and test changes that work on both Hive 2 and
Hive 3 to minimize thechanges required when upgrading to Hive 3.

- Uses the Hive `schematool` to initialize the derby database in the
MiniHms. This fixes issues with autoCreate and is more representative of a
production environment.
- Adjust logging configuration in the MiniHms to be more explicit.
- Workaround HADOOP-8719 by hardcoding the HADOOP_OS_TYPE.
- Workaround HIVE-21614 by using `LIKE` instead of `=` when filtering
tables.

Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
---
M src/kudu/hms/CMakeLists.txt
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/mini_hms.cc
M src/kudu/hms/mini_hms.h
M src/kudu/util/subprocess.cc
M src/kudu/util/subprocess.h
M thirdparty/package-hadoop.sh
8 files changed, 55 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14018/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 )

Change subject: Prepare for upgrading to Hive 3
......................................................................


Patch Set 2:

(4 comments)

LGTM, just some nits.

http://gerrit.cloudera.org:8080/#/c/14018/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14018/2//COMMIT_MSG@10
PS2, Line 10: thechanges
nit: space.


http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.h
File src/kudu/hms/mini_hms.h:

http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.h@134
PS2, Line 134:   bool schema_initialized_ = false;
nit: add a comment for this?


http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.cc@158
PS2, Line 158: // Remove after HADOOP-15966 is available (Hadoop 3.1.3+)
Should this be TODO?


http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.cc@252
PS2, Line 252: Disables the authorization on the DbNotificationListener related metastore APIs.
The comment on HiveConf.java seems to be more clear, so something like 'Disables the authorization on the DbNotificationListener related metastore APIs such as get_next_notification. If set to true, then only the superusers in proxy settings have the permission.



-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 08 Aug 2019 18:01:14 +0000
Gerrit-HasComments: Yes

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 )

Change subject: Prepare for upgrading to Hive 3
......................................................................


Patch Set 1:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/14018/1//COMMIT_MSG
Commit Message:

PS1: 
> Just curious: why are you wrapping your commit messages so aggressively? Th
No specific reason, the edit window was recently adjusted. Switched back.


http://gerrit.cloudera.org:8080/#/c/14018/1//COMMIT_MSG@13
PS1, Line 13: initialized
> initialize
Done


http://gerrit.cloudera.org:8080/#/c/14018/1//COMMIT_MSG@17
PS1, Line 17: MiniHMS
> Nit: MiniHms (or change MiniHms above to MiniHMS).
Done


http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/hms_catalog.cc
File src/kudu/hms/hms_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/hms_catalog.cc@233
PS1, Line 233:       // NOTE: LIKE filters are used instead of = filters due to HIVE-21614
> Does this have a tangible impact on performance (on a non-Derby HMS)? Any w
I did a bit of research and it seems that the effect of LIKE vs = should be near negligible when special characters like % are not used. In the case of Kudu, this is always the case.


http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/mini_hms.cc@158
PS1, Line 158: 
             :   // Set HADOOP_OS_TYPE=Linux due to HADOOP-8719.
             :   // Remove after HADOOP-15966 is available (Hadoop 3.1.3+)
             :   env_vars.insert({ "HADOOP_OS_TYPE", "Linux" });
> Can this be combined into the env_vars declaration above?
Done


http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/mini_hms.cc@310
PS1, Line 310: 
> Please rationalize these new parameters above.
Done


http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/mini_hms.cc@320
PS1, Line 320: 
             :   <property>
             :     <name>hive.async.log.enabled</name>
             :     <value>false</value>
             :   </property>
> I experimented with this but didn't find that it made any difference w.r.t.
I could remove it, it was precautionary more than anything.


http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/util/subprocess.cc
File src/kudu/util/subprocess.cc:

http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/util/subprocess.cc@726
PS1, Line 726:     p.SetEnvVars(env_vars);
> Could you pass env_vars by value and std::move() it here?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Aug 2019 18:52:54 +0000
Gerrit-HasComments: Yes

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 )

Change subject: Prepare for upgrading to Hive 3
......................................................................


Patch Set 1:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/14018/1//COMMIT_MSG
Commit Message:

PS1: 
Just curious: why are you wrapping your commit messages so aggressively? The longest line here is 52 characters; I think 70ish (I use 76) is more typical.


http://gerrit.cloudera.org:8080/#/c/14018/1//COMMIT_MSG@13
PS1, Line 13: initialized
initialize


http://gerrit.cloudera.org:8080/#/c/14018/1//COMMIT_MSG@17
PS1, Line 17: MiniHMS
Nit: MiniHms (or change MiniHms above to MiniHMS).


http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/hms_catalog.cc
File src/kudu/hms/hms_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/hms_catalog.cc@233
PS1, Line 233:       // NOTE: LIKE filters are used instead of = filters due to HIVE-21614
Does this have a tangible impact on performance (on a non-Derby HMS)? Any way to measure?


http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/mini_hms.cc@158
PS1, Line 158: 
             :   // Set HADOOP_OS_TYPE=Linux due to HADOOP-8719.
             :   // Remove after HADOOP-15966 is available (Hadoop 3.1.3+)
             :   env_vars.insert({ "HADOOP_OS_TYPE", "Linux" });
Can this be combined into the env_vars declaration above?


http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/mini_hms.cc@310
PS1, Line 310: 
Please rationalize these new parameters above.


http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/hms/mini_hms.cc@320
PS1, Line 320: 
             :   <property>
             :     <name>hive.async.log.enabled</name>
             :     <value>false</value>
             :   </property>
I experimented with this but didn't find that it made any difference w.r.t. logging. Is it actually important? Or can it be removed?


http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/util/subprocess.cc
File src/kudu/util/subprocess.cc:

http://gerrit.cloudera.org:8080/#/c/14018/1/src/kudu/util/subprocess.cc@726
PS1, Line 726:     p.SetEnvVars(env_vars);
Could you pass env_vars by value and std::move() it here?



-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Aug 2019 17:51:32 +0000
Gerrit-HasComments: Yes

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 )

Change subject: Prepare for upgrading to Hive 3
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14018/5/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

http://gerrit.cloudera.org:8080/#/c/14018/5/src/kudu/hms/mini_hms.cc@156
PS5, Line 156:       { "HADOOP_CONF_DIR", data_root_ },
Is the a duplicate for line 152?


http://gerrit.cloudera.org:8080/#/c/14018/5/src/kudu/hms/mini_hms.cc@158
PS5, Line 158: TODO(ghenke)
nit: maybe, replace with

TODO(HADOOP-15966): remove after the issue is addressed (Hadoop 3.1.3+)

?



-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 15 Aug 2019 20:01:23 +0000
Gerrit-HasComments: Yes

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14018 )

Change subject: Prepare for upgrading to Hive 3
......................................................................

Prepare for upgrading to Hive 3

This patch contains build and test changes that work on both Hive 2 and
Hive 3 to minimize the changes required when upgrading to Hive 3.

- Uses the Hive `schematool` to initialize the derby database in the
MiniHms. This fixes issues with autoCreate and is more representative of a
production environment.
- Adjust logging configuration in the MiniHms to be more explicit.
- Workaround HADOOP-8719 by hardcoding the HADOOP_OS_TYPE.
- Workaround HIVE-21614 by using `LIKE` instead of `=` when filtering
tables.

Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Reviewed-on: http://gerrit.cloudera.org:8080/14018
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/hms/CMakeLists.txt
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/mini_hms.cc
M src/kudu/hms/mini_hms.h
M src/kudu/util/subprocess.cc
M src/kudu/util/subprocess.h
M thirdparty/package-hadoop.sh
8 files changed, 58 insertions(+), 23 deletions(-)

Approvals:
  Hao Hao: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14018

to look at the new patch set (#3).

Change subject: Prepare for upgrading to Hive 3
......................................................................

Prepare for upgrading to Hive 3

This patch contains build and test changes that work on both Hive 2 and
Hive 3 to minimize the changes required when upgrading to Hive 3.

- Uses the Hive `schematool` to initialize the derby database in the
MiniHms. This fixes issues with autoCreate and is more representative of a
production environment.
- Adjust logging configuration in the MiniHms to be more explicit.
- Workaround HADOOP-8719 by hardcoding the HADOOP_OS_TYPE.
- Workaround HIVE-21614 by using `LIKE` instead of `=` when filtering
tables.

Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
---
M src/kudu/hms/CMakeLists.txt
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/mini_hms.cc
M src/kudu/hms/mini_hms.h
M src/kudu/util/subprocess.cc
M src/kudu/util/subprocess.h
M thirdparty/package-hadoop.sh
8 files changed, 58 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14018/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: Prepare for upgrading to Hive 3
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 )

Change subject: Prepare for upgrading to Hive 3
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14018/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14018/2//COMMIT_MSG@10
PS2, Line 10: thechanges
> nit: space.
Done


http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.h
File src/kudu/hms/mini_hms.h:

http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.h@134
PS2, Line 134:   bool schema_initialized_ = false;
> nit: add a comment for this?
Done


http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.cc@158
PS2, Line 158: // Remove after HADOOP-15966 is available (Hadoop 3.1.3+)
> Should this be TODO?
Done


http://gerrit.cloudera.org:8080/#/c/14018/2/src/kudu/hms/mini_hms.cc@252
PS2, Line 252: Disables the authorization on the DbNotificationListener related metastore APIs.
> The comment on HiveConf.java seems to be more clear, so something like 'Dis
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 08 Aug 2019 20:16:20 +0000
Gerrit-HasComments: Yes

[kudu-CR] Prepare for upgrading to Hive 3

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 )

Change subject: Prepare for upgrading to Hive 3
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If43ae2330b3d99374c68bae313a3f8bc070f9c69
Gerrit-Change-Number: 14018
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 08 Aug 2019 20:52:12 +0000
Gerrit-HasComments: No