You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2015/10/02 19:04:58 UTC

[GitHub] spark pull request: [SPARK-9622] [ML] DecisionTreeRegressor: provi...

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8866#discussion_r41043325
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala ---
    @@ -39,7 +40,7 @@ import org.apache.spark.sql.DataFrame
     @Experimental
     final class DecisionTreeRegressor(override val uid: String)
       extends Predictor[Vector, DecisionTreeRegressor, DecisionTreeRegressionModel]
    -  with DecisionTreeParams with TreeRegressorParams {
    +  with TreeRegressorParams {
    --- End diff --
    
    This is a breaking API change.  Is it necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org