You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/04 09:15:29 UTC

[GitHub] [spark] asmello commented on a change in pull request #23882: [SPARK-26979][PYTHON] Add missing string column name support for some SQL functions

asmello commented on a change in pull request #23882: [SPARK-26979][PYTHON] Add missing string column name support for some SQL functions
URL: https://github.com/apache/spark/pull/23882#discussion_r261973265
 
 

 ##########
 File path: python/pyspark/sql/functions.py
 ##########
 @@ -48,6 +48,17 @@ def _(col):
     return _
 
 
+def _create_function(name, doc=""):
+    """ Create a column-based function by name"""
 
 Review comment:
   I did test it manually; isn't that what it says?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org