You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2021/05/04 16:03:52 UTC
[echarts] branch enhance-visual-regression-test updated:
test(visual): add replay buttons
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch enhance-visual-regression-test
in repository https://gitbox.apache.org/repos/asf/echarts.git
The following commit(s) were added to refs/heads/enhance-visual-regression-test by this push:
new c382330 test(visual): add replay buttons
c382330 is described below
commit c382330ba2f9b7393a1fc0e3eded5eb503fd4a2a
Author: pissang <bm...@gmail.com>
AuthorDate: Wed May 5 00:02:34 2021 +0800
test(visual): add replay buttons
---
test/runTest/client/client.css | 7 +++++++
test/runTest/client/client.js | 19 +++++++++++--------
test/runTest/client/index.html | 26 +++++++-------------------
3 files changed, 25 insertions(+), 27 deletions(-)
diff --git a/test/runTest/client/client.css b/test/runTest/client/client.css
index 5b071f6..0806529 100644
--- a/test/runTest/client/client.css
+++ b/test/runTest/client/client.css
@@ -232,6 +232,13 @@
text-decoration: underline;
}
+.single-test-ops {
+ padding: 20px 20px 0 10px;
+}
+.single-test-ops .el-button {
+ margin-left: 10px;
+}
+
.test-screenshots {
margin-top: 20px;
padding: 0 20px;
diff --git a/test/runTest/client/client.js b/test/runTest/client/client.js
index bf1db75..cf86d47 100644
--- a/test/runTest/client/client.js
+++ b/test/runTest/client/client.js
@@ -128,8 +128,7 @@ const app = new Vue({
runConfig: Object.assign({
sortBy: 'name',
- noHeadless: false,
- replaySpeed: 5,
+ // replaySpeed: 5,
isActualNightly: false,
isExpectedNightly: false,
@@ -312,8 +311,8 @@ const app = new Vue({
this.tests[i].selected = selected;
}
},
- runSingleTest(testName) {
- runTests([testName]);
+ runSingleTest(testName, noHeadless) {
+ runTests([testName], noHeadless);
},
run(runTarget) {
let tests;
@@ -329,7 +328,7 @@ const app = new Vue({
else {
tests = this.fullTests;
}
- runTests(tests.map(test => test.name));
+ runTests(tests.map(test => test.name), false);
},
stopTests() {
this.running = false;
@@ -389,11 +388,15 @@ const app = new Vue({
id: runResult.id
});
}).catch(() => {});
+ },
+
+ open(url, target) {
+ window.open(url, target);
}
}
});
-function runTests(tests) {
+function runTests(tests, noHeadless) {
if (!tests.length) {
app.$notify({
title: 'No test selected.',
@@ -415,9 +418,9 @@ function runTests(tests) {
actualVersion: app.runConfig.actualVersion,
threads: app.runConfig.threads,
renderer: app.runConfig.renderer,
- noHeadless: app.runConfig.noHeadless,
+ noHeadless,
replaySpeed: app.runConfig.noHeadless
- ? app.runConfig.replaySpeed
+ ? 1
: 5 // Force run at 5x speed
});
}
diff --git a/test/runTest/client/index.html b/test/runTest/client/index.html
index 8aae895..259dc15 100644
--- a/test/runTest/client/index.html
+++ b/test/runTest/client/index.html
@@ -140,18 +140,6 @@ under the License.
</el-tooltip>
</div>
-
- <!-- <div class="run-config-item">
- <el-checkbox v-model="runConfig.noHeadless">Replay</el-checkbox>
- <el-slider
- style="width: 80px;"
- v-model="runConfig.replaySpeed"
- :step="1" :min="1" :max="10"
- show-stops
- :format-tooltip="function(val) { return val + 'x'; }"
- :disabled="!runConfig.noHeadless"
- ></el-slider>
- </div> -->
<div class="run-config-item">
<span class="label">
Expected
@@ -207,14 +195,14 @@ under the License.
style="margin-top: 5px;"
></el-progress>
<h3>{{currentTest.name}}</h3>
- <el-button-group style="margin-left: 10px" v-if="running">
- <el-button :loading="running" circle type="primary"></el-button>
- <el-button title="Run Selected" @click="stopTests" circle type="primary" icon="el-icon-close"></el-button>
+ </div>
+ <div class="single-test-ops">
+ <el-button-group>
+ <el-button :loading="running" size="mini" @click="runSingleTest(currentTest.name)" type="primary" icon="el-icon-caret-right">Run Single</el-button>
+ <el-button :loading="running" size="mini" @click="runSingleTest(currentTest.name, true)">Replay</el-button>
</el-button-group>
- <el-button v-else style="margin-left: 10px" title="Run Selected" @click="runSingleTest(currentTest.name)" circle type="primary" icon="el-icon-caret-right"></el-button>
- </el-button>
- <a target="_blank" :href="currentTestUrl"><i class="el-icon-link"></i> Open Demo</a>
- <a target="_blank" :href="currentTestRecordUrl"><i class="el-icon-video-camera"></i> Record Interaction</a>
+ <el-button size="mini" @click="open(currentTestUrl, '_blank')" icon="el-icon-link">Open Demo</el-button>
+ <el-button size="mini" @click="open(currentTestRecordUrl, '_blank')" icon="el-icon-video-camera">Record Interaction</el-button>
</div>
<div v-if="currentTest.results.length > 0">
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org