You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/04 17:35:11 UTC
[GitHub] [spark] viirya commented on a change in pull request #30246: [SPARK-33338][SQL] GROUP BY using literal map should not fail
viirya commented on a change in pull request #30246:
URL: https://github.com/apache/spark/pull/30246#discussion_r517515681
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -316,6 +316,8 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
(value, o.value) match {
case (null, null) => true
case (a: Array[Byte], b: Array[Byte]) => util.Arrays.equals(a, b)
+ case (a: ArrayBasedMapData, b: ArrayBasedMapData) =>
+ a.keyArray == b.keyArray && a.valueArray == b.valueArray
Review comment:
Quick question, why we don't have `equals` in `ArrayBasedMapData`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org