You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/05 12:23:51 UTC

[GitHub] [incubator-superset] dpgaspar opened a new pull request #9091: [datasources] Fix, Prevent gamma user's from accessing save datasources

dpgaspar opened a new pull request #9091: [datasources] Fix, Prevent gamma user's from accessing save datasources
URL: https://github.com/apache/incubator-superset/pull/9091
 
 
   ### CATEGORY
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Prevent `Gamma` user's from saving/updating datasources
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on issue #9091: [datasources] Fix, Prevent gamma user's from accessing save datasources

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9091: [datasources] Fix, Prevent gamma user's from accessing save datasources
URL: https://github.com/apache/incubator-superset/pull/9091#issuecomment-582408516
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9091?src=pr&el=h1) Report
   > Merging [#9091](https://codecov.io/gh/apache/incubator-superset/pull/9091?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916d184076f39c83c7a9f96de7ab8653955d5238?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9091/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9091?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9091   +/-   ##
   =======================================
     Coverage   59.15%   59.15%           
   =======================================
     Files         370      370           
     Lines       11818    11818           
     Branches     2900     2900           
   =======================================
     Hits         6991     6991           
     Misses       4648     4648           
     Partials      179      179
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9091?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9091?src=pr&el=footer). Last update [916d184...4cb3b02](https://codecov.io/gh/apache/incubator-superset/pull/9091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch merged pull request #9091: [datasources] Fix, Prevent gamma user's from accessing save datasources

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #9091: [datasources] Fix, Prevent gamma user's from accessing save datasources
URL: https://github.com/apache/incubator-superset/pull/9091
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org