[GitHub] [incubator-seatunnel] laglangyue commented on a diff in pull request #2633: [Bug][e2e] the e2e exec error in win10, fix path separator

[GitBox <gi...@apache.org>]

laglangyue commented on code in PR #2633:
URL: https://github.com/apache/incubator-seatunnel/pull/2633#discussion_r962876719


##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/spark/SparkContainer.java:
##########
@@ -97,7 +97,8 @@ public Container.ExecResult executeSeaTunnelSparkJob(String confFile) throws IOE
         // Running IT use cases under Windows requires replacing \ with /
         String conf = targetConfInContainer.replaceAll("\\\\", "/");
         final List<String> command = new ArrayList<>();
-        command.add(Paths.get(SEATUNNEL_HOME, "bin", SEATUNNEL_SPARK_BIN).toString());
+        String sparkSh = Paths.get(SEATUNNEL_HOME, "bin", SEATUNNEL_SPARK_BIN).toString();

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org