[GitHub] [beam] kileys commented on a diff in pull request #17274: BEAM-13468 allow non-lts jvm version

[GitBox <gi...@apache.org>]

kileys commented on code in PR #17274:
URL: https://github.com/apache/beam/pull/17274#discussion_r925947724


##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java:
##########
@@ -112,6 +116,20 @@ public String specification() {
     }
 
     public static JavaVersion forSpecification(String specification) {
+      for (JavaVersion ver : JavaVersion.values()) {
+        if (ver.specification.equals(specification)) {
+          return ver;
+        }
+      }
+      JavaVersion fallback = java11;

Review Comment:
   Instead of always falling back to 11, could we find the nearest LTS version to fall back to?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org