You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Corey Nolet <cj...@gmail.com> on 2015/01/26 19:51:06 UTC
Review Request 30280: ACCUMULO-3533 Making
AbstractInputFormat.getConfiguration() protected to match backwards
compatibility with 1.6.1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30280/
-----------------------------------------------------------
Review request for accumulo, Sean Busbey, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
Repository: accumulo
Description
-------
ACCUMULO-3533 Moving the getConfiguration logic which uses reflection to guarantee Hadoop 1 & 2 compatiblity to its own util class outside of the public API. Making the AbstractInputFormat.getConfiguration() protected once again.
Diffs
-----
ACCUMULO-3533.patch PRE-CREATION
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java bcbfddc
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormat.java c68dd56
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormat.java 010a94f
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 0f495f0
core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java a60cb80
core/src/main/java/org/apache/accumulo/core/util/HadoopCompatUtil.java PRE-CREATION
examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java 1b8cbaf
Diff: https://reviews.apache.org/r/30280/diff/
Testing
-------
Basic build with unit tests.
Thanks,
Corey Nolet
Re: Review Request 30280: ACCUMULO-3533 Making
AbstractInputFormat.getConfiguration() protected to match backwards
compatibility with 1.6.1
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30280/#review69674
-----------------------------------------------------------
Ship it!
Ship It!
- Josh Elser
On Jan. 26, 2015, 7:04 p.m., Corey Nolet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30280/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 7:04 p.m.)
>
>
> Review request for accumulo, Sean Busbey, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
>
>
> Bugs: ACCUMULO-3533
> https://issues.apache.org/jira/browse/ACCUMULO-3533
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-3533 Moving the getConfiguration logic which uses reflection to guarantee Hadoop 1 & 2 compatiblity to its own util class outside of the public API. Making the AbstractInputFormat.getConfiguration() protected once again.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java bcbfddc
> core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormat.java c68dd56
> core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormat.java 010a94f
> core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 0f495f0
> core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java a60cb80
> core/src/main/java/org/apache/accumulo/core/util/HadoopCompatUtil.java PRE-CREATION
> examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java 1b8cbaf
>
> Diff: https://reviews.apache.org/r/30280/diff/
>
>
> Testing
> -------
>
> Basic build with unit tests.
>
>
> Thanks,
>
> Corey Nolet
>
>
Re: Review Request 30280: ACCUMULO-3533 Making
AbstractInputFormat.getConfiguration() protected to match backwards
compatibility with 1.6.1
Posted by Corey Nolet <cj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30280/
-----------------------------------------------------------
(Updated Jan. 26, 2015, 7:04 p.m.)
Review request for accumulo, Sean Busbey, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
Bugs: ACCUMULO-3533
https://issues.apache.org/jira/browse/ACCUMULO-3533
Repository: accumulo
Description
-------
ACCUMULO-3533 Moving the getConfiguration logic which uses reflection to guarantee Hadoop 1 & 2 compatiblity to its own util class outside of the public API. Making the AbstractInputFormat.getConfiguration() protected once again.
Diffs (updated)
-----
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java bcbfddc
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormat.java c68dd56
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormat.java 010a94f
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 0f495f0
core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java a60cb80
core/src/main/java/org/apache/accumulo/core/util/HadoopCompatUtil.java PRE-CREATION
examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java 1b8cbaf
Diff: https://reviews.apache.org/r/30280/diff/
Testing
-------
Basic build with unit tests.
Thanks,
Corey Nolet
Re: Review Request 30280: ACCUMULO-3533 Making
AbstractInputFormat.getConfiguration() protected to match backwards
compatibility with 1.6.1
Posted by Corey Nolet <cj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30280/
-----------------------------------------------------------
(Updated Jan. 26, 2015, 2:02 p.m.)
Review request for accumulo, Sean Busbey, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
Bugs: ACCUMULO-3533
https://issues.apache.org/jira/browse/ACCUMULO-3533
Repository: accumulo
Description
-------
ACCUMULO-3533 Moving the getConfiguration logic which uses reflection to guarantee Hadoop 1 & 2 compatiblity to its own util class outside of the public API. Making the AbstractInputFormat.getConfiguration() protected once again.
Diffs (updated)
-----
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java bcbfddc
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormat.java c68dd56
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormat.java 010a94f
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 0f495f0
core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java a60cb80
core/src/main/java/org/apache/accumulo/core/util/HadoopCompatUtil.java PRE-CREATION
examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java 1b8cbaf
Diff: https://reviews.apache.org/r/30280/diff/
Testing
-------
Basic build with unit tests.
Thanks,
Corey Nolet
Re: Review Request 30280: ACCUMULO-3533 Making
AbstractInputFormat.getConfiguration() protected to match backwards
compatibility with 1.6.1
Posted by Corey Nolet <cj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30280/
-----------------------------------------------------------
(Updated Jan. 26, 2015, 6:55 p.m.)
Review request for accumulo, Sean Busbey, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
Repository: accumulo
Description
-------
ACCUMULO-3533 Moving the getConfiguration logic which uses reflection to guarantee Hadoop 1 & 2 compatiblity to its own util class outside of the public API. Making the AbstractInputFormat.getConfiguration() protected once again.
Diffs (updated)
-----
ACCUMULO-3533.patch PRE-CREATION
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java bcbfddc
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormat.java c68dd56
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormat.java 010a94f
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 0f495f0
core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java a60cb80
core/src/main/java/org/apache/accumulo/core/util/HadoopCompatUtil.java PRE-CREATION
examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java 1b8cbaf
Diff: https://reviews.apache.org/r/30280/diff/
Testing
-------
Basic build with unit tests.
Thanks,
Corey Nolet
Re: Review Request 30280: ACCUMULO-3533 Making
AbstractInputFormat.getConfiguration() protected to match backwards
compatibility with 1.6.1
Posted by Corey Nolet <cj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30280/
-----------------------------------------------------------
(Updated Jan. 26, 2015, 6:55 p.m.)
Review request for accumulo, Sean Busbey, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
Repository: accumulo
Description
-------
ACCUMULO-3533 Moving the getConfiguration logic which uses reflection to guarantee Hadoop 1 & 2 compatiblity to its own util class outside of the public API. Making the AbstractInputFormat.getConfiguration() protected once again.
Diffs (updated)
-----
ACCUMULO-3533.patch PRE-CREATION
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java bcbfddc
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormat.java c68dd56
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormat.java 010a94f
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 0f495f0
core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java a60cb80
core/src/main/java/org/apache/accumulo/core/util/HadoopCompatUtil.java PRE-CREATION
examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java 1b8cbaf
Diff: https://reviews.apache.org/r/30280/diff/
Testing
-------
Basic build with unit tests.
Thanks,
Corey Nolet
Re: Review Request 30280: ACCUMULO-3533 Making
AbstractInputFormat.getConfiguration() protected to match backwards
compatibility with 1.6.1
Posted by Corey Nolet <cj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30280/
-----------------------------------------------------------
(Updated Jan. 26, 2015, 6:53 p.m.)
Review request for accumulo, Sean Busbey, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
Changes
-------
Can still use getConfiguration() in InputFormatBase
Repository: accumulo
Description
-------
ACCUMULO-3533 Moving the getConfiguration logic which uses reflection to guarantee Hadoop 1 & 2 compatiblity to its own util class outside of the public API. Making the AbstractInputFormat.getConfiguration() protected once again.
Diffs (updated)
-----
ACCUMULO-3533.patch PRE-CREATION
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java bcbfddc
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormat.java c68dd56
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormat.java 010a94f
core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 0f495f0
core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java a60cb80
core/src/main/java/org/apache/accumulo/core/util/HadoopCompatUtil.java PRE-CREATION
examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java 1b8cbaf
Diff: https://reviews.apache.org/r/30280/diff/
Testing
-------
Basic build with unit tests.
Thanks,
Corey Nolet