You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/20 18:32:38 UTC
[GitHub] codecov-io commented on issue #5253: Revert "[perf] add webpack 4 +
SplitChunks + lazy load visualizations"
codecov-io commented on issue #5253: Revert "[perf] add webpack 4 + SplitChunks + lazy load visualizations"
URL: https://github.com/apache/incubator-superset/pull/5253#issuecomment-398852009
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5253?src=pr&el=h1) Report
> Merging [#5253](https://codecov.io/gh/apache/incubator-superset/pull/5253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93cdf60920dc6234771876a195838c6458b80e3d?src=pr&el=desc) will **increase** coverage by `2.9%`.
> The diff coverage is `56.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5253?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5253 +/- ##
=========================================
+ Coverage 60.76% 63.66% +2.9%
=========================================
Files 258 261 +3
Lines 19708 20126 +418
Branches 1972 2079 +107
=========================================
+ Hits 11976 12814 +838
+ Misses 7723 7301 -422
- Partials 9 11 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5253?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/markup.js](https://codecov.io/gh/apache/incubator-superset/pull/5253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9tYXJrdXAuanM=) | `26.66% <ø> (+26.66%)` | :arrow_up: |
| [superset/assets/src/visualizations/time\_table.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90aW1lX3RhYmxlLmpzeA==) | `16.81% <0%> (+16.81%)` | :arrow_up: |
| [...et/assets/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TbGljZUhlYWRlci5qc3g=) | `31.14% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/index.js](https://codecov.io/gh/apache/incubator-superset/pull/5253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9pbmRleC5qcw==) | `100% <100%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.34% <100%> (ø)` | :arrow_up: |
| [...ssets/src/visualizations/deckgl/layers/scatter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL3NjYXR0ZXIuanN4) | `27.83% <100%> (+27.83%)` | :arrow_up: |
| [superset/assets/src/components/Loading.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xvYWRpbmcuanN4) | `87.5% <100%> (ø)` | :arrow_up: |
| [...ts/src/visualizations/deckgl/layers/screengrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL3NjcmVlbmdyaWQuanN4) | `38.18% <100%> (+38.18%)` | :arrow_up: |
| [superset/assets/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydC5qc3g=) | `65% <48.38%> (+8.47%)` | :arrow_up: |
| [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `72.32% <75%> (-0.79%)` | :arrow_down: |
| ... and [60 more](https://codecov.io/gh/apache/incubator-superset/pull/5253/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5253?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5253?src=pr&el=footer). Last update [93cdf60...c033c2f](https://codecov.io/gh/apache/incubator-superset/pull/5253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org