[GitHub] ajantha-bhat commented on a change in pull request #3089: [HOTFIX] presto carbon doesn't work with Hadoop conf in cluster.

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #3089: [HOTFIX] presto carbon doesn't work with Hadoop conf in cluster. 
URL: https://github.com/apache/carbondata/pull/3089#discussion_r249692634
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
 ##########
 @@ -178,6 +180,16 @@ public static String getSchemaFilePath(String tablePath) {
     return getActualSchemaFilePath(tablePath);
   }
 
+  /**
+   * return the schema file path
+   * @param tablePath path to table files
+   * @param hadoopConf hadoop configuration object
+   * @return schema file path
+   */
+  public static String getSchemaFilePath(String tablePath, Configuration hadoopConf) {
 
 Review comment:
   If you check the caller old getSchemaFilePath, many places it is used. cannot pass null config in all the places. 
   That's why used method overloading concept as it is applicable here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services